Adds an info text if the campaign has overdelivered to inform user about the max budget to be charged

[therocket-gr]

closes 3099-gh-tumblr/a8c-dsp

Proposed Changes

This is a simple PR to add a notice to the user if the campaign has over-delivered (only in evergreen campaigns) to inform the user about the maximum charged amount

UPDATE

please ignore the below.. the proposed changes would look like the below - we changed a bit the wording

first attempt

the result looks like this

Testing Instructions

to test in localhost you can override this line

const weeklySpend =

(line 274 of the same file client/my-sites/promote-post-i2/components/campaign-item-details/index.tsx to a number greater then the total budget)

you should see the info text right below the weekly spend area (as shown above in the ss)

do a CR

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-140442

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-140442&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-140442&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~59 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
promote-post-i2       +185 B  (+0.0%)      +59 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• command-palette-wp-admin
• help-center
• notifications
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug vdimitrakis/3099-inform-user-about-max-weekly-budget-to-charge on your sandbox.

[bo2]

Thanks @therocket-gr !

Can we make it more calm? These marketing messages are good when user see them rarely, but make everyday UI element sound that excessive may be too intense.

[therocket-gr]

Thanks @therocket-gr !

Can we make it more calm? These marketing messages are good when user see them rarely, but make everyday UI element sound that excessive may be too intense.

what do you think about this

"Your campaign performed well this week. You’ll still only be charged your set weekly budget of $35."

[timur987]

Thanks @therocket-gr!

LGTM and works as advertised.

[sbarbosa]

LGTM 👍

[bo2]

I asked Bart to take a look, as we plan to add another message there for the CPC experiment

[bartoszbak]

Messaging sounds good although I'd shorten it so it says necessary things.

From: Great news! Your campaign did really well this week,, but don't worry - we won't charge you more that your weekly budget.

To: Your campaign outperformed this week! You’ll only be charged up to your budget.

I'd also visually higher so people don't confuse this information with a simple subtitle :)

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17397315

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @therocket-gr for including a screenshot in the description! This is really helpful for our translators.