Skip to content

Reader Editor: Add Tracks events when editor card opens and closes #102228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

DustyReagan
Copy link
Contributor

@DustyReagan DustyReagan commented Mar 31, 2025

Related to pe7F0s-2C4-p2

Proposed Changes

  • Adds tracks events when the Reader Editor card opens and closes.

Why are these changes being made?

  • To measure engagement with the Reader Editor.

Testing Instructions

  • Use Calypso Live
  • Go to /reader
  • In your browser console type localStorage.setItem( 'debug', 'calypso:analytics*' ); and refresh the page
  • Open and close the Reader Editor foldable card.
  • You should see the calypso_reader_editor_card_opened and calypso_reader_editor_card_closed Tracks events in your browser console log.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Mar 31, 2025

@DustyReagan DustyReagan changed the title Add tracks when editor card opens and closes Reader Editor: Add Tracks events when editor card opens and closes Mar 31, 2025
@DustyReagan DustyReagan self-assigned this Mar 31, 2025
@DustyReagan DustyReagan marked this pull request as ready for review March 31, 2025 14:42
@DustyReagan DustyReagan requested a review from a team as a code owner March 31, 2025 14:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 31, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~30 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader       +104 B  (+0.0%)      +30 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/reader-editor-card-open-tracks on your sandbox.

Copy link
Contributor

@artemiomorales artemiomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@DustyReagan DustyReagan merged commit 3dd3938 into trunk Mar 31, 2025
18 of 19 checks passed
@DustyReagan DustyReagan deleted the add/reader-editor-card-open-tracks branch March 31, 2025 15:11
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants