-
Notifications
You must be signed in to change notification settings - Fork 2k
Domains: Fix discrepancy between onboarding and domain-only search #102021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 13 commits
d60a5c1
ee8cd45
7407629
bd58718
64d1ab9
156dc84
637dbb4
6a02845
7f93736
242557e
5a340fb
c50e337
1739d61
a28071e
d219a88
02dff5d
ca33aaf
81c8a5c
d465f55
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
@import "@wordpress/base-styles/breakpoints"; | ||
@import "@wordpress/base-styles/mixins"; | ||
@import "@wordpress/base-styles/variables"; | ||
@import "@wordpress/base-styles/colors.native"; | ||
|
||
.domains__step-section-wrapper { | ||
margin: 0 auto; | ||
|
@@ -519,22 +520,59 @@ body.is-section-signup { | |
.step-route.onboarding.domains:has(.step-container-v2) { | ||
padding: 0; | ||
|
||
.register-domain-step__search-card { | ||
margin: 0; | ||
.register-domain-step { | ||
&__search-card { | ||
@media (min-width: 600px) { | ||
margin: 20px 20px 0; | ||
} | ||
|
||
@media (min-width: 960px) { | ||
margin: 0; | ||
} | ||
} | ||
|
||
&__domain-side-content-container-domain-explanation-image { | ||
max-width: 100%; | ||
margin-bottom: 0; | ||
} | ||
|
||
&__example-prompt { | ||
margin: 0; | ||
|
||
@media (min-width: 600px) { | ||
margin: 0 20px; | ||
} | ||
} | ||
} | ||
|
||
.featured-domain-suggestions, | ||
.domain-suggestion { | ||
margin-inline: 0; | ||
} | ||
|
||
.register-domain-step__domain-side-content-container-domain-explanation-image { | ||
max-width: 100%; | ||
margin-bottom: 0; | ||
@media (min-width: 600px) { | ||
margin-inline: 20px; | ||
|
||
@media (min-width: 960px) { | ||
margin: 0; | ||
} | ||
} | ||
} | ||
|
||
.register-domain-step__example-prompt { | ||
margin: 0; | ||
.featured-domain-suggestions { | ||
border-top: none; | ||
|
||
@media (min-width: 600px) { | ||
margin: 0 20px; | ||
|
||
@media (min-width: 960px) { | ||
margin: 0; | ||
} | ||
} | ||
|
||
.featured-domain-suggestion { | ||
margin: 0; | ||
margin-bottom: 12px; | ||
} | ||
} | ||
|
||
.domains__domain-side-content-container { | ||
|
@@ -550,9 +588,119 @@ body.is-section-signup { | |
@include break-medium { | ||
max-width: 290px; | ||
} | ||
|
||
@include break-large { | ||
margin-left: 40px; | ||
} | ||
|
||
@include break-huge { | ||
margin-left: 60px; | ||
} | ||
|
||
&.fade-out { | ||
display: none; | ||
} | ||
} | ||
|
||
.domains__domain-side-content.fade-out { | ||
display: none; | ||
.step-container-v2__heading { | ||
h1:not(.small) { | ||
letter-spacing: -0.4px; | ||
/* stylelint-disable-next-line declaration-property-unit-allowed-list */ | ||
line-height: 1.2em; | ||
} | ||
|
||
> p { | ||
color: $gray-60; | ||
font-size: 1rem; | ||
} | ||
} | ||
} | ||
|
||
.step-container-v2 { | ||
&__content.step-container-v2__content--two-column-layout.domains__step-content.domains__step-content-domain-step { | ||
column-gap: 0; | ||
max-width: 1280px; | ||
} | ||
|
||
&__content-wrapper.padding { | ||
padding: 0 12px; | ||
gap: 0; | ||
} | ||
|
||
&__heading { | ||
margin-top: 0; | ||
} | ||
} | ||
|
||
.domains__step-content-domain-step > div { | ||
&:nth-child(1) { | ||
flex: 1 !important; | ||
} | ||
|
||
&:nth-child(2) { | ||
display: flex; | ||
flex-basis: auto !important; | ||
flex-direction: column; | ||
flex-grow: 0 !important; | ||
flex-shrink: 1 !important; | ||
flex-wrap: nowrap; | ||
} | ||
} | ||
|
||
.domain-product-price { | ||
&.domain-product-single-price.domain-product-price__domain-step-signup-flow { | ||
align-self: center; | ||
} | ||
|
||
@include breakpoint-deprecated( "<660px" ) { | ||
&.domain-product-price__domain-step-signup-flow { | ||
flex-direction: column; | ||
} | ||
} | ||
} | ||
|
||
.domain-suggestion__content.domain-suggestion__content-domain { | ||
align-items: unset; | ||
} | ||
|
||
body.is-section-stepper { | ||
.featured-domain-suggestion.card .domain-product-price { | ||
align-items: flex-start; | ||
margin-top: 12px; | ||
} | ||
|
||
.formatted-header .formatted-header__title { | ||
@media (min-width: 1080px) { | ||
font-size: 2.75rem !important; | ||
} | ||
} | ||
|
||
.register-domain-step__search.register-domain-step__search-domain-step:not(.is-sticky) { | ||
@media (min-width: 661px) { | ||
padding-top: 18px; | ||
} | ||
} | ||
|
||
.onboarding:not(.is-onboarding-2023-pricing-grid) .step-container-v2__heading { | ||
margin: calc(48px + 24px - var(--step-container-v2-top-bar-height)) 20px 24px 20px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as here - but a different viewport/media query, thus a different calculated value. |
||
display: flex; | ||
flex-wrap: wrap; | ||
justify-content: space-between; | ||
width: unset; | ||
align-items: center; | ||
flex-direction: column; | ||
|
||
@media (min-width: 960px) { | ||
margin-top: calc(48px + 48px - var(--step-container-v2-top-bar-height)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is calculated based on the domain-only component - its margins/paddings are used to determine which should be the top here, along with the variable from the height of the different bar used in this flow. |
||
margin-bottom: 36px; | ||
} | ||
|
||
> h1 { | ||
font-size: 2.25rem; | ||
|
||
@media (min-width: 1080px) { | ||
font-size: 2.75rem; | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wp-calypso/client/components/formatted-header/style.scss
Lines 110 to 111 in 7800534
Since we're replicating this referenced style in here, we need to disable the rule as well too.