Skip to content

Add back logging out #102015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2025
Merged

Add back logging out #102015

merged 3 commits into from
Mar 27, 2025

Conversation

robertsreberski
Copy link
Contributor

Related to #

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-138791
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-138791&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-138791&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Mar 27, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~26 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login       +218 B  (+0.0%)      +26 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@robertsreberski robertsreberski merged commit 54afb7e into trunk Mar 27, 2025
11 of 12 checks passed
@robertsreberski robertsreberski deleted the fix/jetpack-auth-improvements-6 branch March 27, 2025 23:36
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 27, 2025
View reviewed changes
manzoorwanijk added a commit that referenced this pull request Apr 25, 2025
@manzoorwanijk
Revert "Add back logging out (#102015)"
b9b1c88 
This reverts commit 54afb7e.
manzoorwanijk added a commit that referenced this pull request Apr 29, 2025
@manzoorwanijk
Revert jetpack onboarding i1 changes (#102882)
344e73a 
* Revert "Properly handle redirect_to in fallback login page (#102117)"

This reverts commit 24f8f5e.

* Revert "Jetpack Onboarding: various auth improvements (#102106)"

This reverts commit da747fd.

* Revert "Improve error handling in auth flows (#102027)"

This reverts commit fd52d8c.

* Revert "My Jetpack: redirect logged in users to the connection page (#102644)"

This reverts commit 6a41e3e.

* Revert "Improve log in handling for Google (#102018)"

This reverts commit 30b8af0.

* Revert "Add back logging out (#102015)"

This reverts commit 54afb7e.

* Revert "Fix Apple and GitHub redirects (#102011)"

This reverts commit f39b9e4.

* Revert "Next bunch on auth improvements (#101996)"

This reverts commit 3de680b.

* Revert "Various improvements of direct Jetpack auth (#101988)"

This reverts commit 7a3558a.

* Revert "Improve error redirects (#101865)"

This reverts commit e2c6064.

* Revert "MARTECH-42 Various Jetpack direct auth improvements and fixes (#101859)"

This reverts commit d49fc76.

* Revert "Add direct GitHub auth and callback server-side (#101672)"

This reverts commit bec8c74.

* Revert "Do not run Jetpack social auth endpoints on serverside (#101832)"

This reverts commit 2d915a9.

* Revert "Remove oauth env checks in social auth Jetpack (#101802)"

This reverts commit 0639270.

* Revert "Revert the improvement to the original code (#101801)"

This reverts commit d959108.

* Revert "Fix nonce handling in auth request (#101800)"

This reverts commit 013bd4e.

* Revert "JPMT-31 Apple authentication endpoint for Jetpack (#101658)"

This reverts commit 0c55e09.

* Revert "JPMT-30 Add direct Google auth endpoint for Jetpack (#101588)"

This reverts commit 93dbf58.

* Revert "Support auto trigger of magiclink auth (#101601)"

This reverts commit 2984e31.

* Revert "JPMT-29 Improve Google Auth handling based on testing (#101508)"

This reverts commit 7011770.

* Revert "JPMT-29 Add direct authentication endpoints for social providers (#101427)"

This reverts commit b45e821.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsreberski @matticbot