Skip to content

Reader Editor: Remove the Cancel button #102013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

DustyReagan
Copy link
Contributor

@DustyReagan DustyReagan commented Mar 27, 2025

Related to p1743105394127549-slack-C083J8DHLLD

Proposed Changes

  • Removes the "Cancel" button from the Reader Editor.
Before After
Screenshot 2025-03-27 at 5 47 31 PM Screenshot 2025-03-27 at 5 46 57 PM

Why are these changes being made?

  • The "Cancel" button clears the editor in one click with no confirmation or undo. We could change its behavior, but have opted to simply remove it.

Testing Instructions

  • Use Calypso Live
  • Go to /reader
  • Confirm that the "Cancel" button is gone.
  • Make sure you can still post from the Reader Editor.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@DustyReagan DustyReagan self-assigned this Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

@DustyReagan DustyReagan marked this pull request as ready for review March 27, 2025 22:49
@DustyReagan DustyReagan requested a review from a team as a code owner March 27, 2025 22:49
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~22 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
reader       -106 B  (-0.0%)      -22 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan merged commit a2e7283 into trunk Mar 28, 2025
18 checks passed
@DustyReagan DustyReagan deleted the remove/reader-editor-cancel-btn branch March 28, 2025 13:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants