Skip to content

Login: Update styles and layout of QR code screen #102010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025
Merged

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Mar 27, 2025

Related to #100443, DOTCOM-36

Proposed Changes

  • Remove the second heading
  • Remove card styling and align all text next to the QR code
  • Add the (w) logo to the top left
  • Update the notice styling and text

Why are these changes being made?

Consistency

Screenshots

Before After
Default before-default after-default
Error state before-error after-error
Woo login before-woo after-woo

Note that the (w) branding appears for the Woo, Akismet, etc login flows as well, rather than the specific branding. IMO, changing that would probably require duplicating code or maybe refactoring how the login screens work (I think), so I didn't pursue that here.

Testing Instructions

  • Go to log in
  • Click "Log in via Jetpack app"
  • See the QR code

QR logins available for:

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ryelle ryelle self-assigned this Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

@matticbot
Copy link
Contributor

matticbot commented Mar 27, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~40 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login       +975 B  (+0.0%)      +40 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Async-loaded Components (~4349 bytes added 📈 [gzipped])

name                                     parsed_size            gzip_size
async-load-calypso-blocks-qr-code-login     +11261 B  (+56.5%)    +4349 B  (+57.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 27, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/login-qr-screen on your sandbox.

@fditrapani
Copy link
Contributor

Thanks for getting this started! Looks so much better already! I have some minor comments:

  • When you go from the login page to the this one, there's a big layout shift. The email me a link option is centred and the shift feels less noticeable. Can we vertically centre this layout too?
  • Can we update "Tap the Me Tab." to "Tap the Me tab." It matches the next point by bolding the name of the thing you have to action on and changes tab to lowercase.
  • Can we left align the title for Woo. I know their screens have the centre aligned title but it looks weird in the column like that. It should look fine with the text centre aligned since the block is centred

@ryelle ryelle force-pushed the update/login-qr-screen branch from 8b570ce to e327bb2 Compare March 28, 2025 16:29
@ryelle
Copy link
Contributor Author

ryelle commented Mar 28, 2025

Here are those updates- centered layout, updated "Me" text, and fixed the Woo layout. I also noticed the link in the instructions was a different font size, so I've fixed that too.

Screen Shot 2025-03-28 at 12 20 37

Screen Shot 2025-03-28 at 12 30 43

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on my end! Thanks for the update

@ryelle ryelle added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Authentication Everything login and authentication. labels Mar 31, 2025
@ramonjd
Copy link
Member

ramonjd commented Apr 4, 2025

I'll give this a quick test and merge next week. Thanks folks.

@ramonjd ramonjd self-assigned this Apr 4, 2025
@ryelle ryelle removed their assignment Apr 4, 2025
@ramonjd ramonjd force-pushed the update/login-qr-screen branch from e327bb2 to 2ac1b5c Compare April 7, 2025 04:00
@ramonjd ramonjd merged commit 58f2955 into trunk Apr 7, 2025
13 checks passed
@ramonjd ramonjd deleted the update/login-qr-screen branch April 7, 2025 04:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 7, 2025
@a8ci18n
Copy link

a8ci18n commented Apr 7, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17366625

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @ryelle for including a screenshot in the description! This is really helpful for our translators.

JessBoctor pushed a commit to JessBoctor/wp-calypso that referenced this pull request Apr 15, 2025
* Login: Update styles and layout of QR code screen

* Add the WordPress logo to QR login screen

* Update instructions text

* Fix woo text alignment and link size

* Center the content vertically on page
JessBoctor pushed a commit to JessBoctor/wp-calypso that referenced this pull request Apr 17, 2025
* Login: Update styles and layout of QR code screen

* Add the WordPress logo to QR login screen

* Update instructions text

* Fix woo text alignment and link size

* Center the content vertically on page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Authentication Everything login and authentication.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants