-
Notifications
You must be signed in to change notification settings - Fork 2k
Login: Update styles and layout of QR code screen #102010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~40 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Async-loaded Components (~4349 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Thanks for getting this started! Looks so much better already! I have some minor comments:
|
8b570ce
to
e327bb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great on my end! Thanks for the update
I'll give this a quick test and merge next week. Thanks folks. |
e327bb2
to
2ac1b5c
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17366625 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @ryelle for including a screenshot in the description! This is really helpful for our translators. |
* Login: Update styles and layout of QR code screen * Add the WordPress logo to QR login screen * Update instructions text * Fix woo text alignment and link size * Center the content vertically on page
* Login: Update styles and layout of QR code screen * Add the WordPress logo to QR login screen * Update instructions text * Fix woo text alignment and link size * Center the content vertically on page
Related to #100443, DOTCOM-36
Proposed Changes
Why are these changes being made?
Consistency
Screenshots
Note that the (w) branding appears for the Woo, Akismet, etc login flows as well, rather than the specific branding. IMO, changing that would probably require duplicating code or maybe refactoring how the login screens work (I think), so I didn't pursue that here.
Testing Instructions
QR logins available for:
Pre-merge Checklist