-
Notifications
You must be signed in to change notification settings - Fork 2k
Onboarding Copy Polish: Update plans page copy #101873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~66 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~66 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17316250 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @vykes-mac for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @vykes-mac. Looks great!
const isOnboarding = isOnboardingFlow( flowName ?? null ); | ||
|
||
const renderSubheader = () => { | ||
if ( createWithBigSky ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a subtle logic change here. I think if createWithBigSky
is true then this function should return
<>
<Subheader>
{ translate( 'Build your ....' ) }
</Subheader>
{ showPlanBenefits && <PlanBenefitHeader />
</>
I don't think I can test this logic anymore though, because you can't choose big sky before getting to the plans step anymore. The plans component in Calypso doesn't show this sub header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely correct. The big sky header can be rendered along with the plans benefit header. It seems like we should remove the big sky related copy here since they are basically unused now that BigSky is after plans page?
Translation for this Pull Request has now been finished. |
Closes #98848
Proposed Changes
Why are these changes being made?
Testing Instructions
/setup/onboarding
and continue to plans page.Paid domain

Free domain

Pre-merge Checklist