Skip to content

Onboarding Copy Polish: Update plans page copy #101873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025
Merged

Conversation

vykes-mac
Copy link
Contributor

Closes #98848

Proposed Changes

  • Update plans page title and subtile

Why are these changes being made?

Testing Instructions

  • Go to /setup/onboarding and continue to plans page.
  • Verify copy is correct when a free domain is selected
  • Select a paid domain and verify copy
  • Test domain upsell flow that there are no regression

Paid domain
image

Free domain
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Mar 26, 2025

@vykes-mac vykes-mac requested review from fditrapani and a team March 26, 2025 02:38
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 26, 2025
@vykes-mac vykes-mac self-assigned this Mar 26, 2025
@vykes-mac vykes-mac added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Mar 26, 2025
@matticbot
Copy link
Contributor

matticbot commented Mar 26, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~66 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
plugins                         +65 B  (+0.0%)      +69 B  (+0.0%)
plans                           +65 B  (+0.0%)      +69 B  (+0.0%)
jetpack-app                     +65 B  (+0.0%)      +69 B  (+0.1%)
async-step-unified-plans        +58 B  (+0.0%)      +66 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~66 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +58 B  (+0.0%)      +66 B  (+0.0%)
async-load-signup-steps-plans                          +58 B  (+0.0%)      +66 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 26, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plans-page-copy on your sandbox.

@a8ci18n
Copy link

a8ci18n commented Mar 26, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17316250

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @vykes-mac for including a screenshot in the description! This is really helpful for our translators.

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @vykes-mac. Looks great!

const isOnboarding = isOnboardingFlow( flowName ?? null );

const renderSubheader = () => {
if ( createWithBigSky ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a subtle logic change here. I think if createWithBigSky is true then this function should return

<>
	<Subheader>
		{ translate( 'Build your ....' ) }
	</Subheader>
	{ showPlanBenefits && <PlanBenefitHeader />
</>

I don't think I can test this logic anymore though, because you can't choose big sky before getting to the plans step anymore. The plans component in Calypso doesn't show this sub header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely correct. The big sky header can be rendered along with the plans benefit header. It seems like we should remove the big sky related copy here since they are basically unused now that BigSky is after plans page?

@a8ci18n
Copy link

a8ci18n commented Mar 30, 2025

Translation for this Pull Request has now been finished.

@vykes-mac vykes-mac merged commit 3e6880e into trunk Apr 1, 2025
13 checks passed
@vykes-mac vykes-mac deleted the update/plans-page-copy branch April 1, 2025 01:48
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plans page in onboaring flow
5 participants