This repository was archived by the owner on May 21, 2025. It is now read-only.
Upgrade to latest Node LTS v18 #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinksi
added
the
type: task
Jinksi
changed the title
Jinksi
commented
Oct 28, 2022
There was a problem hiding this comment.
Currently, when running on node v18, npm run build results in the error below.
It looks like we'll be forced to upgrade some packages starting with @wordpress/scripts.
wp-scripts build assets/src/js/index.js
node_modules/loader-runner/lib/LoaderRunner.js:114
throw e;
^
Error: error:0308010C:digital envelope routines::unsupported
postcss dep was added as a dev dependency to fix build script error
4 tasks
|
Subscriptions Core has now been archived. For more information, please refer to this announcement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230
Description
How to test this PR
nvm installfrom this repo's directory.nvm use. You should now be using Node v18.x.npm install. You should not see anUnsupported enginewarning.npm run build. The build should complete successfully.npm installwarning related to unsupported engines.@es-joy/[email protected][email protected].These occur due to
@woocommerce/eslint-pluginand@wordpress/scripts.npm run buildworks as expected without errors../buildhave minor changes, presumably due to updating@wordpress/scripts.package-lock.jsonreflects any changes related to the node/npm version upgrade.Product impact