Merge finalized release 2.19 #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mokagio merged 3 commits into trunk from release/2.19

Aug 10, 2023

Contributor

mokagio commented Aug 10, 2023

Fastlane localized release_notes.txt updates
Localized .strings updates – N.A. in this release
Build number bump in version .xcconfig file
(Optional) Plus diffs from the PRs that landed on the release branch since the last beta – N.A.

mokagio added 3 commits

August 10, 2023 13:13


          Update metadata translations

fdc33f8


          Bump version number

776b64e


          Add source files for support_url and copyright metadata

05f34c1

This was a result of Fastlane warning us about those metadata missing:

```
[13:20:30]: 😵  Failed: Incorrect, or missing copyright date-> using a copyright date that is any different from this current year, or missing a date
[13:20:32]: 😵  Failed: No broken urls-> unreachable URLs in app metadata
+------------------------+----------------+
|           Potential problems            |
+------------------------+----------------+
| Field                  | Failure reason |
+------------------------+----------------+
| copyright              | missing: 2023  |
| support URL: (fr-FR)   | empty url      |
| support URL: (sv)      | empty url      |
| support URL: (ja)      | empty url      |
| support URL: (nl-NL)   | empty url      |
| support URL: (ru)      | empty url      |
| support URL: (de-DE)   | empty url      |
| support URL: (id)      | empty url      |
| support URL: (tr)      | empty url      |
| support URL: (zh-Hans) | empty url      |
| support URL: (es-ES)   | empty url      |
| support URL: (it)      | empty url      |
| support URL: (ko)      | empty url      |
| support URL: (zh-Hant) | empty url      |
| support URL: (pt-BR)   | empty url      |
+------------------------+----------------+
[13:20:32]: precheck 👮‍♀️ 👮  found one or more potential metadata problems, but this won't prevent fastlane from completing 👍
```

mokagio requested a review from a team

August 10, 2023 03:53

mokagio added the Releases label

mokagio enabled auto-merge

August 10, 2023 03:54

mokagio mentioned this pull request

Thread hang risk #1104

Open

mokagio merged commit 9a7b900 into trunk

oguzkocer approved these changes

View reviewed changes

mokagio deleted the release/2.19 branch

August 14, 2023 02:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels