Skip to content

Chore: Dependencies update #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 12, 2025
Merged

Chore: Dependencies update #3292

merged 21 commits into from
Feb 12, 2025

Conversation

codebykat
Copy link
Contributor

@codebykat codebykat commented Feb 12, 2025 •
edited
Loading

Fix

  • Fix vulnerable dependencies: cookie, webpack, @sentry/react
  • bump node version
  • Some electron packages and other fairly straightforward updates to packages
  • Will NOT "eff-eye-ex" Ubuntu 24.04: Simplenote 2.22.2 doesn't start #3284, despite my hopes, I cannot get electron-builder post version 24 to build properly. See commit + reversion for more info. Looks like we need to wait on an updated version of electron/rebuild

Test

  1. npm install --legacy-peer-deps
  2. npm run dev
  3. Smoke-test the app
  4. verify packages build and test them as well

n.b. this introduces a console error, Error: unrecognized flag --no-expose-wasm, which is harmless (due to a chromium version pulled in by electron).

Release

RELEASE-NOTES.md was updated with:

Upgraded dependencies

@codebykat codebykat marked this pull request as ready for review February 12, 2025 11:07
@codebykat codebykat self-assigned this Feb 12, 2025
roundhill
roundhill approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well! Nice to see the node 20 bump :D

@codebykat
update node version
709aa88
@codebykat
update vulnerable packages @sentry/react and cookie
b320670
@codebykat
add caniuse per console nag to update defs
a07c835
@codebykat
update webpack for vulnerability
670ca2e
@codebykat
update electron and related packages
9d20ccb
@codebykat
electron-builder breaks after v25, which is a prerelease
bdc3409
@codebykat
try to fix electron-builder errors, no dice
4ca62bb
@codebykat
Revert "try to fix electron-builder errors, no dice"
e97654b 
This reverts commit afc774b.

Seems to be an issue with electron/rebuild.

See: electron/rebuild#1116

Similar issue: rancher-sandbox/rancher-desktop#7409

For config changes see: electron-userland/electron-builder#8556
@codebykat
release notes
301d9bd
@codebykat
package updates, mostly style related
09fc7a0
@codebykat
package updates, mostly types
17678b8
@codebykat
html-webpack-plugin
4f0c437
@codebykat
core-js
ab6a408
@codebykat
react-modal
a9b0609
@codebykat
webpack-cli
7a6d332
@codebykat
typescript and eslint related mostly
b20676d
@codebykat
fake-indexeddb
1aa07fe
@codebykat
revert package updates that got moved into the sass PR
3d85f7c
@codebykat
remove package updates that got moved to the other PRs
0f712f4
@codebykat
revert prettier for now
3c1c7ff
@codebykat
rebase conflict resolution
80fdc36
@codebykat codebykat merged commit 51cf6d3 into trunk Feb 12, 2025
7 checks passed
@codebykat codebykat deleted the update/deps-2025-02 branch February 12, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roundhill roundhill roundhill approved these changes

@mokagio mokagio Awaiting requested review from mokagio

Assignees

@codebykat codebykat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebykat @roundhill