Skip to content

Update: Clear tracks data when logging out #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2024
Merged

Update: Clear tracks data when logging out #3269

merged 3 commits into from
Nov 4, 2024

Conversation

codebykat
Copy link
Contributor

@codebykat codebykat commented Oct 30, 2024 •
edited
Loading

Fix

Fixes this issue about the tk cookie sticking around: https://hackerone.com/reports/2793499

Will close https://github.com/Automattic/simplenote-gae/issues/644

Test

  1. Log in and have analytics enabled (if it was disabled, you might want to log out and log back in to make sure the cookie gets set)
  2. Log out
  3. Verify that the tk_id cookie no longer has the signed-in email address

Release

@codebykat codebykat self-assigned this Oct 30, 2024
@codebykat codebykat requested a review from roundhill October 30, 2024 22:46
@codebykat codebykat marked this pull request as ready for review October 31, 2024 15:16
roundhill
roundhill approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, the tk_ cookies were removed! Thank you @codebykat

@codebykat codebykat merged commit 00a9aa1 into trunk Nov 4, 2024
7 checks passed
@codebykat codebykat deleted the update/remove_tracks_cookies_on_logout branch November 4, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roundhill roundhill roundhill approved these changes

Assignees

@codebykat codebykat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebykat @roundhill