fix(TextMetrics): rtl direction + start/end textAlign #2510
+53
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaMan123
commented
Apr 30, 2025
chearon
requested changes
May 3, 2025
| it("2d.type class string", function () { | ||
| const canvas = createCanvas(100, 50); | ||
| const ctx = canvas.getContext("2d"); | ||
| assert.strictEqual(Object.prototype.toString.call(ctx), '[object CanvasRenderingContext2D]') |
There was a problem hiding this comment.
Did this need to be removed?
There was a problem hiding this comment.
I ran npm run generate-wpt - this is outdated code I believe
test/wpt/text-styles.yaml
Outdated
|
|
||
| ctx.textAlign = "left" | ||
| metrics = ctx.measureText('hello'); | ||
| @assert metrics.actualBoundingBoxLeft < metrics.actualBoundingBoxRight; |
There was a problem hiding this comment.
I don't think this goes here. This test is imported from the WPT tests, so it would get overwritten if they did any updates. You should be able to write this in canvas.test.js though.
There was a problem hiding this comment.
I thought the yaml files generate the js test files. Regardless I saw nothing runs these tests on CI
This reverts commit 7f782ae.
ShaMan123
commented
May 3, 2025
| @@ -2557,6 +2557,20 @@ inline double getBaselineAdjustment(PangoLayout* layout, short baseline) { | |||
| } | |||
| } | |||
|
|
|||
| text_align_t | |||
There was a problem hiding this comment.
Should I expose a strict text align enum?
enum text_align_strict_t : int8_t {
STRICT_TEXT_ALIGNMENT_LEFT = TEXT_ALIGNMENT_LEFT,
STRICT_TEXT_ALIGNMENT_CENTER = TEXT_ALIGNMENT_CENTER,
STRICT_TEXT_ALIGNMENT_RIGHT = TEXT_ALIGNMENT_RIGHT
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
closes #2508