Virtuals not called on update queries

[gcanu]

mongoose : 4.12.4
nodeJs : 8.2.1
mongoDB : 3.4.6

Hello,

Here's an enhancement purpose : currently, virtuals are not called when I use update queries like findByIdAndUpdate. You recently added a great feature : runSettersOnQuery but virtuals still not called. This because object contains update is casted before applySetters called, and fields that does not match model are removed...

I use virtual to make encryption/decryption on few fields, and it's not possible to use this very useful feature with update queries. It's possible to use save instead, but not always, especially when you have an object which contains new values...

Best regards

[vkarpov15]

So you're thinking virtual setters, like if you call .update({ password: 'abc' }) it would get translated to updating passwordSalt and encryptedPassword as in #5762 ? That's a very interesting idea, but very difficult to do without #5770. That way:

User.virtual('password').set(function generate(v) {
  this.set('passwordSalt', encryptor.salt())
  this.set('encryptedPassword', encryptor.hash(v, this.passwordSalt))
})

Can work for both documents and queries. Does that sound reasonable?

[gcanu]

Yes, thanks !

Property encryption/decryption is doable with both virtuals and getters/setters without any difficulties. Virtual seems the most elegant way to achieve this feature. But it's just my personal opinion !

[akash-gupt]

@gcanu @wvl @wvl @Sija is it working?

[Sija]

@techaks Couldn't tell, I haven't touched Mongoose for yrs...

[mamousavi]

@vkarpov15 Any plans on passing the query instance to virtual setters for update commands?

[akash-gupt]

@vkarpov15 Any plans on passing the query instance to virtual setters for update commands?

try some hack to fix this. they are not working on this issue

[mamousavi]

Fixed it with a query middleware:

schema.pre('findOneAndUpdate', function(next) {
  const update = this.getUpdate();
  Object.keys(update)
    .filter((path) => schema.pathType(path) === 'virtual')
    .forEach((name) => {
      schema.virtualpath(name).applySetters(update[name], this);
    });
  next();
});