feat(core): added a bunch more common rules #940

elijah-potter · 2025-03-20T14:18:26Z

Description

I've gone ahead and added a bunch more phrase corrections.

Checklist

I have performed a self-review of my own code
I have added tests to cover my changes

try to disable in my fork

ccoVeille · 2025-03-20T18:52:00Z

harper-core/src/linting/for_noun.rs

+    }
+
+    fn description(&self) -> &'static str {
+        "Corrects the archaic or mistaken `fro` to `for` when followed by a noun."


Suggested change

"Corrects the archaic or mistaken `fro` to `for` when followed by a noun."

"Corrects the archaic or mistaken `fro` to `for`, or `from` when followed by a noun."

It could be a typo about fro used instead of from

I received a letter fro Sarah
I received a letter from Sarah

Also, while fro is archaic, it's irrelevant since it's not an archaic form of for. It's an archaic form of from and is only used these days in to and fro.

I wonder if some logic for rare/archaic words could have a flag in the dictionary to allow them to get a warning and still undergo spellcheck. We'd want to find other instances similar to fro for that to be worthwhile. I know that back in the day spellcheck dictionaries purposefully left words out that were correct but rare and likely to cause confusion.

Would you suggest we change the description, or remove this rule as well as the dictionary entry for fro?

Would you suggest we change the description, or remove this rule as well as the dictionary entry for fro?

I would probably test if the spellcheck handles it. I've noticed it often doesn't make what I consider the 'obvious' suggestions for many mistakes. I haven't checked this one.

If the spellcheck suggests 'for' and 'from' we can probably do without the rule, but if it fails to suggest those then it's probably worth keeping the rule with a changed description.

At some point we probably want to add some code to 'score' suggestions in other ways than just pure edit distance to help get the best 3 into the suggestions.

That's been around for a while now. See harper-core/src/spell/mod.rs fn score_suggestion. I've tweaked it a bit, but I'm not sure how to achieve the desired behavior.

I think we should keep the rule with an updated description.

That's been around for a while now. See harper-core/src/spell/mod.rs fn score_suggestion. I've tweaked it a bit, but I'm not sure how to achieve the desired behavior.

Nice! I hadn't spotted it - will play with it at some point.

elijah-potter · 2025-04-03T18:43:06Z

I have no idea what is going here with all the merge commits.

hippietrail · 2025-04-03T18:48:14Z

I have no idea what is going here with all the merge commits.

I think about a month ago I tried to submit a PR to your PR or feature branch... or something like that. And it seemed to work at the time... but it seems to have caused this awfulness in the longer run.

The worst case could be if my master somehow got in there because I turned off some of the GitHub CI stuff that didn't work in my fork and just kept causing recurring errors in my inbox.

If it's my fault I sincerely apologize!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.26.0` -> `v0.29.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.29.1`](https://github.com/Automattic/harper/releases/tag/v0.29.1) [Compare Source](Automattic/harper@v0.29.0...v0.29.1) #### What's Changed - chore: "off of a" false positive by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1081 - feat: phrase corrections: like a plague, have went, case and point, aswell by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1078 - Dictionary curation 2025 04 17 by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1080 - fix: [#1075](Automattic/harper#1075) package logo font for vscode extension by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1077 **Full Changelog**: Automattic/harper@v0.29.0...v0.29.1 ### [`v0.29.0`](https://github.com/Automattic/harper/releases/tag/v0.29.0) [Compare Source](Automattic/harper@v0.28.0...v0.29.0) #### What's Changed - refactor: remove unneeded logic for repeated words by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1020 - fix: improve to handle -s -es and -ed endings by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1003 - feat: start clarifying affix system by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#972 - refactor: improve logic and robustness of then→than by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1021 - Curate existing rules by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1023 - fix: new logic and false positives by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1024 - build(deps): bump tokio from 1.44.1 to 1.44.2 by [@dependabot](https://github.com/dependabot) in Automattic/harper#1040 - build(deps): bump indexmap from 2.8.0 to 2.9.0 by [@dependabot](https://github.com/dependabot) in Automattic/harper#1037 - build(deps): bump uuid from 1.12.0 to 1.16.0 by [@dependabot](https://github.com/dependabot) in Automattic/harper#1038 - feat: use the old code if `parallel` unavailable by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1019 - feat: mention which verb triggered lint in msg by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1034 - feat: Expand "cuz", correct "on face value" by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1030 - feat: exempt "you guys" from the possessive your linter by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1027 - feat: trail and error→trial and error by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1044 - chore: tweak priority/position of statusbar item and add Harper logo by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1043 - chore: "side of a" false positive by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1029 - feat: Add special cases to sentence capitalization by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1031 - feat: don't allow "let's" to trigger a following compound by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1032 - Dictionary curation 2025 04 04 by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1028 - feature: highly kept (secret)→well-kept by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1045 - Documentation updates by [@mcecode](https://github.com/mcecode) in Automattic/harper#1000 - chore: manually spotted 3 things our lints would flag in doc comments by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1047 - feat: sequential pronouns: don't detect "my US", make case insensitive by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1026 - feat(devshell): init devshell by [@alDuncanson](https://github.com/alDuncanson) in Automattic/harper#1014 - `harper.js` API reference generation improvements by [@mcecode](https://github.com/mcecode) in Automattic/harper#1050 - fix(comments): ignore comments CSpell compatibility by [@mcecode](https://github.com/mcecode) in Automattic/harper#1046 - fix: update vscode deps by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1042 - feat: hone in on→home in on by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1059 - Adj of a curation 2025 04 09 by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1053 - Dictionary curation 2025 04 08 by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1052 - fix: make modal-of linter case insensitive by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1048 - build(deps): bump clap from 4.5.34 to 4.5.36 by [@dependabot](https://github.com/dependabot) in Automattic/harper#1060 - build(deps): bump anyhow from 1.0.97 to 1.0.98 by [@dependabot](https://github.com/dependabot) in Automattic/harper#1063 - build(deps): bump lru from 0.13.0 to 0.14.0 by [@dependabot](https://github.com/dependabot) in Automattic/harper#1061 - build(deps): bump smallvec from 1.14.0 to 1.15.0 by [@dependabot](https://github.com/dependabot) in Automattic/harper#1062 - feat(core): add simple corrections from my notes by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1025 - Fix bug 1066 "Stack Overflow", dictionary curation, adjective-of-a curation by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1068 - feat: add for (a)while, after (a)while, unless if, suffice to say by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1071 **Full Changelog**: Automattic/harper@v0.28.0...v0.29.0 ### [`v0.28.0`](https://github.com/Automattic/harper/releases/tag/v0.28.0) [Compare Source](Automattic/harper@v0.27.0...v0.28.0) #### What's Changed - fix(vscode-plugin): sleep a longer time after openUntitled by [@kiding](https://github.com/kiding) in Automattic/harper#1004 - docs: update link to website by [@alDuncanson](https://github.com/alDuncanson) in Automattic/harper#1007 - feat(harper-cli): make lint accept user & file-local dictionary by [@kiding](https://github.com/kiding) in Automattic/harper#987 - feat(ls): use PlainEnglish parser for language id "text" by [@86xsk](https://github.com/86xsk) in Automattic/harper#968 - docs: fix grammar by [@alDuncanson](https://github.com/alDuncanson) in Automattic/harper#1009 - feat(comments): add `scala` support by [@tymcauley](https://github.com/tymcauley) in Automattic/harper#970 - docs(core): update the `Author a Rule` page to align with code by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1008 - feat(core): make `LintConfig` sorted by key by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1012 - feat: wrote first draft of statistics logging by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#454 - feat(obsidian): add debounce setting by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1015 - feat(harper.js): significantly improve worker performance by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1016 - feat: [#20](Automattic/harper#20) : comma spacing and [#498](Automattic/harper#498) : Asian commas by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#891 - feat(core): added a bunch more common rules by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#940 - chore: merge and sort original and non-US sections by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#977 - Adj of a curation 2025 04 02 by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#1006 #### New Contributors - [@alDuncanson](https://github.com/alDuncanson) made their first contribution in Automattic/harper#1007 - [@tymcauley](https://github.com/tymcauley) made their first contribution in Automattic/harper#970 **Full Changelog**: Automattic/harper@v0.27.0...v0.28.0 ### [`v0.27.0`](https://github.com/Automattic/harper/releases/tag/v0.27.0) [Compare Source](Automattic/harper@v0.26.0...v0.27.0) #### What's Changed - fix(harper-ls): handle language mode change and VS Code auto detect by [@kiding](https://github.com/kiding) in Automattic/harper#966 - feat: linters for common mistakes with "another" by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#963 - Dictionary curation 2025 03 06 by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#837 - feat(core): flag "<adjective> of a" by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#967 - fix: include the full set of personal pronouns and possessives by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#964 - fix: 2 words in curated dict lack / before annotations by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#958 - feat: implement [#828](Automattic/harper#828) by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#853 - VS Code Extension Updates by [@mcecode](https://github.com/mcecode) in Automattic/harper#960 - doc(core): write up the difference between a `Linter` and a `PatternLinter` by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#973 - fix(core): remove bad phrase by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#974 - fix: handle another false positive in "adjective of a" by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#980 - feat(harper-typst): ignore file path as arguments, regex, .display by [@kiding](https://github.com/kiding) in Automattic/harper#976 - Improve doc coverage by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#979 - feat: detect capitalized false positives by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#988 - fix(harper-cli): set American as the default dialect by [@kiding](https://github.com/kiding) in Automattic/harper#986 - build(deps): bump once_cell from 1.21.1 to 1.21.3 by [@dependabot](https://github.com/dependabot) in Automattic/harper#996 - feat: more false positives: "inside of" & "out of" by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#992 - template for feature requests on github by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#981 - build(deps): bump clap from 4.5.32 to 4.5.34 by [@dependabot](https://github.com/dependabot) in Automattic/harper#995 - feat: implement [#993](Automattic/harper#993) by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#994 - Dialect indicator for VS Code extension by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#985 - chore: "head of a" false positive + test by [@hippietrail](https://github.com/hippietrail) in Automattic/harper#999 - test(core): confirm that [#720](Automattic/harper#720) is no longer present by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#975 - fix(wordpress): crashes when options menu is opened by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1002 **Full Changelog**: Automattic/harper@v0.26.0...v0.27.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

hippietrail added 30 commits January 17, 2025 15:10

Update fuzz.yml

72016af

try to disable in my fork

Merge branch 'Automattic:master' into master

25efa8c

Merge branch 'Automattic:master' into master

84281ca

Merge branch 'Automattic:master' into master

820e54d

Merge branch 'Automattic:master' into master

d3407a0

Merge branch 'Automattic:master' into master

a29c5c5

Merge branch 'Automattic:master' into master

25a1cc7

Merge branch 'Automattic:master' into master

132ac5b

Merge branch 'Automattic:master' into master

fdaa2d4

Merge branch 'Automattic:master' into master

8ab290a

Merge branch 'Automattic:master' into master

51ee374

Merge branch 'Automattic:master' into master

3adb44b

Merge branch 'Automattic:master' into master

e8171a9

Merge branch 'Automattic:master' into master

2b51499

Merge branch 'Automattic:master' into master

3bc6141

Merge branch 'Automattic:master' into master

4729aae

ignore dotfolders

9c0a010

Merge branch 'Automattic:master' into master

1c0aa2f

Merge branch 'master' of https://github.com/hippietrail/harper

1fa1897

.gitignore mac ds store

6c2fa53

Merge branch 'master' of https://github.com/Automattic/harper

de2959e

Merge branch 'Automattic:master' into master

be4b92f

Merge branch 'master' of https://github.com/hippietrail/harper

dc927d7

Merge branch 'Automattic:master' into master

2a7ee5e

move files to allow sync

9a9e095

move files to allow sync

74a7583

Merge branch 'master' of https://github.com/Automattic/harper

f01c573

Merge branch 'Automattic:master' into master

8f2a785

Merge branch 'Automattic:master' into master

ef0bc1f

delete experimental file

ff34ad4

hippietrail and others added 3 commits March 19, 2025 08:40

Merge branch 'Automattic:master' into master

395d478

feat(core): added a bunch more common rules

09b04d4

Merge branch 'Automattic:master' into master

b82be0d

elijah-potter added harper-core linting labels Mar 20, 2025

hippietrail and others added 2 commits March 20, 2025 23:17

Merge branch 'Automattic:master' into master

591df5a

refactor(core): move fro into own rule

08bd258

ccoVeille suggested changes Mar 20, 2025

View reviewed changes

elijah-potter and others added 15 commits March 20, 2025 13:19

Merge branch 'master' into more-rules

a6dc766

Merge branch 'Automattic:master' into master

06fcbc9

Merge branch 'Automattic:master' into master

e706db4

Merge branch 'Automattic:master' into master

1f536b2

feat(core): adjust spellcheck to prioritize the first letter

ae5e599

Merge branch 'Automattic:master' into master

3f9fbc7

Merge branch 'Automattic:master' into master

c35fdba

Merge branch 'Automattic:master' into master

8ce167e

Merge branch 'Automattic:master' into master

900ab68

Merge branch 'Automattic:master' into master

02ab957

Merge branch 'Automattic:master' into master

f048382

Merge branch 'Automattic:master' into master

77bf671

Merge branch 'Automattic:master' into master

ef479e4

Merge branch 'master' into more-rules

a1162a8

Merge branch 'master' into more-rules

66c8843

elijah-potter added 2 commits April 3, 2025 12:53

fix(action): every 10 minutes

2807ec7

build: remove useless lint call

1928027

elijah-potter merged commit 52a4fe5 into master Apr 3, 2025
22 checks passed

elijah-potter deleted the more-rules branch April 3, 2025 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(core): added a bunch more common rules #940

feat(core): added a bunch more common rules #940

Uh oh!

elijah-potter commented Mar 20, 2025

Uh oh!

ccoVeille Mar 20, 2025

Uh oh!

hippietrail Mar 21, 2025

Uh oh!

elijah-potter Mar 21, 2025

Uh oh!

hippietrail Mar 21, 2025

Uh oh!

elijah-potter Mar 25, 2025 •

edited

Loading

Uh oh!

hippietrail Mar 31, 2025

Uh oh!

elijah-potter commented Apr 3, 2025

Uh oh!

hippietrail commented Apr 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

	"Corrects the archaic or mistaken `fro` to `for` when followed by a noun."
	"Corrects the archaic or mistaken `fro` to `for`, or `from` when followed by a noun."

feat(core): added a bunch more common rules #940

feat(core): added a bunch more common rules #940

Uh oh!

Conversation

elijah-potter commented Mar 20, 2025

Description

Checklist

Uh oh!

ccoVeille Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

hippietrail Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

elijah-potter Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

hippietrail Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

elijah-potter Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hippietrail Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

elijah-potter commented Apr 3, 2025

Uh oh!

hippietrail commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elijah-potter Mar 25, 2025 •

edited

Loading

hippietrail commented Apr 3, 2025 •

edited

Loading