Skip to content

ci: disable packaging and building workflows on draft PRs #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

grantlemons
Copy link
Collaborator

These workflows fail on draft PRs anyway, and I believe they will get run when the draft status is removed.

I still think it's important to have the precommit workflow run, but these others don't seem too important for a draft.

@grantlemons
Copy link
Collaborator Author

grantlemons commented Nov 29, 2024

I was wrong about the reason the workflows were failing, this seems to have been because the Cargo.lock was out of line with master, but I still don't think these need to run. Feel free to close if you disagree @elijah-potter, I don't have a strong opinion on this.

@elijah-potter elijah-potter merged commit 2314e6d into master Nov 30, 2024
17 checks passed
@elijah-potter elijah-potter deleted the draftpr-disable-workflows branch January 21, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants