Skip to content

feat: add clojure support #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jerielverissimo
Copy link
Contributor

@jerielverissimo jerielverissimo commented Jul 7, 2025

Issues

Following this issue

Description

This PR adds a new support for the clojure language, following this guide.

Demo

How Has This Been Tested?

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

@jerielverissimo jerielverissimo marked this pull request as draft July 7, 2025 16:39
@jerielverissimo
Copy link
Contributor Author

Hi @elijah-potter I'm following the guide to add clojure support, but I'm having trouble to test if everything is working.

@elijah-potter
Copy link
Collaborator

Okay, I'll admit that the guide was missing a pretty crucial step: testing.

Here's the gist of what you need to do.

  • Find or write several Clojure files containing grammatical errors. If you can, place these errors in syntactically relevant places (like in doc-comments, if Clojure has those).
  • Place these files in harper-comments/tests/language_support_sources.
  • Add new entries to the bottom of harper-comments/tests/language_support.rs. The second parameter is the number of grammatical errors that Harper should detect in that file.
create_test!(clean.clj, 0);

Run cargo test.

Let me know if you have any questions. If not, I'll add the above explanation to the guide.

@jerielverissimo jerielverissimo marked this pull request as ready for review July 8, 2025 16:54
Copy link
Collaborator

@elijah-potter elijah-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for getting this done.

@elijah-potter elijah-potter enabled auto-merge July 8, 2025 19:47
@elijah-potter elijah-potter added this pull request to the merge queue Jul 8, 2025
Merged via the queue into Automattic:master with commit 814ba9c Jul 8, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants