Skip to content

fix(ls): duplicate lints #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

fix(ls): duplicate lints #1490

merged 2 commits into from
Jul 1, 2025

Conversation

elijah-potter
Copy link
Collaborator

Issues

Fixes #830

Description

We did not deduplicate lints in the language server. Not sure why.

How Has This Been Tested?

Manually.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

@elijah-potter elijah-potter merged commit 49fcf85 into master Jul 1, 2025
23 checks passed
@elijah-potter elijah-potter deleted the fix-dups branch July 1, 2025 19:56
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jul 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.47.0` -> `v0.48.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.48.0`](https://github.com/Automattic/harper/releases/tag/v0.48.0)

[Compare Source](Automattic/harper@v0.47.0...v0.48.0)

#### What's Changed

- feat(core): create linter for discourse markers by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1470
- refactor(core): rename `insert_pattern_rule!` by [@&#8203;86xsk](https://github.com/86xsk) in Automattic/harper#1487
- fix(ls): duplicate lints by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1490
- chore: augment and refactor metadata by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#1488
- fix(core): use tagger to improve certainty in `HowTo` lint by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1489
- feat: replace terms from dialects with local synonyms by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#1475
- feat(core): write linter to detect erroneous use of plurality by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1486
- fix: fix issue 1495 by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#1502
- chore: curate dictionary by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#1501
- test(chrome-ext): on Firefox in Playwright by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1491

**Full Changelog**: Automattic/harper@v0.47.0...v0.48.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In VS Code, the "baited breath"→"bated breath" message appears twice.
1 participant