feat: take sth. serious→take sth. seriously #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippietrail
added
grammar
elijah-potter
approved these changes
Jun 18, 2025
elijah-potter
pushed a commit
that referenced
this pull request
Jun 18, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 24, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.42.0` -> `v0.44.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.44.0`](https://github.com/Automattic/harper/releases/tag/v0.44.0) [Compare Source](Automattic/harper@v0.43.0...v0.44.0) #### What's Changed - feat: split affixes and properties and support propagating properties by [@​RunDevelopment](https://github.com/RunDevelopment) in Automattic/harper#1251 - fix: missing words in [#​1401](Automattic/harper#1401) by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1402 - fix: ensure grey is suggested when gray is wrong by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1403 - feat: take sth. serious→take sth. seriously by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1405 - feat(core): add linter for [#​346](Automattic/harper#346) by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1407 - feat(web): show Firefox link to applicable users by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1409 - feat(chrome-plugin): set up build system for Firefox by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1408 - feat:Shoot oneself into a leg → oneself in the foot by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1391 - chore: re-sort phrase corrections by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1410 - docs: add page for Firefox + update FAQ by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1412 - feat(core): cover case from [#​381](Automattic/harper#381) + remove useless rule by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1416 - feat: add types of determiner by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1415 - Major performance improvements to the Chrome extension by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1417 - feat: handle the recieved→received part of [#​1411](Automattic/harper#1411) by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1418 - fix(chrome-ext): dispatch input events on form els by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1330 - fix(core): use POS tags for `PronounKnew` accuracy by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1413 - feat: Implement [#​405](Automattic/harper#405) - the "5am in the morning" redundancy by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1414 - feat: add "except if" and "except when" for "unless if" by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1318 - feat: touristic → tourist / tourism / touristic by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1345 - fix: some very important adverbs were not marked by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1420 **Full Changelog**: Automattic/harper@v0.43.0...v0.44.0 ### [`v0.43.0`](https://github.com/Automattic/harper/releases/tag/v0.43.0) [Compare Source](Automattic/harper@v0.42.0...v0.43.0) #### What's Changed - refactor(core): `Pattern` -> `Expr` by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1393 - feat: fix nonstandard variants of two idioms by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1392 - feat: update untitled handling by [@​mcecode](https://github.com/mcecode) in Automattic/harper#1385 - build(deps): bump clap from 4.5.39 to 4.5.40 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#1397 - build(deps): bump reqwest from 0.12.19 to 0.12.20 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#1396 - chore: sort alphabetically by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#1399 - build(deps): bump unicode-width from 0.2.0 to 0.2.1 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#1398 - feat(brill): train and use Brill tagger by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#1344 **Full Changelog**: Automattic/harper@v0.42.0...v0.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41Ny4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
Replaces
TakeItSeriouslyinphrase_corrections.rswith a more capable linter.Now matches all forms of the verb
takeand arbitrary nominal phrases.This has uncovered some limitations in
NominalPhrase, especially thatthisandthatare not recognized as pronouns (and hence nominal phrases) because they are recognized as determiners (that would introduce longer nominal phrases).Adverbs between the NP and
seriousare not yet handled.Passive mood is not supported. ie. "be taken serious" with no NP between
takeandserious.How Has This Been Tested?
A range of sentences using this pattern were found on GitHub and converted to tests.
Checklist