Skip to content

Fix test_story_budget_set_number_days_filter_invalid in PHP 8.0 #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Fix test_story_budget_set_number_days_filter_invalid in PHP 8.0 #644

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7083780
Convert $new_filters['number_days'] to int before comparison
htdat May 12, 2021
47fe007
Merge branch 'update/coverage-checker' into fix/phpunit-php8
htdat May 12, 2021
18bbba9
Merge branch 'master' into fix/phpunit-php8
htdat Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/story-budget/story-budget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ public function update_user_filters_from_form_date_range_change( $current_user,
}

if ( isset( $new_filters['number_days'] ) ) {
$new_filters['number_days'] = intval( $new_filters['number_days'] );
if ( $new_filters['number_days'] <= 1 ) {
$existing_filters['number_days'] = 1;
} else {
Expand Down