[Feat] Improve readme and support uploading readme to dockerhub #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shink
reviewed
Apr 22, 2025
pushrm.sh
Outdated
| for registry in ${registries}; do | ||
| if [[ -v target_map[$registry] ]]; then | ||
| target="${target_map[$registry]}" | ||
| docker login ${registry} |
There was a problem hiding this comment.
How to login these registries in CI?
shink
reviewed
Apr 22, 2025
pushrm.sh
Outdated
|
|
||
| readonly file="$1" | ||
| readonly registry_mappings="$2" | ||
| readonly registries="quay.io docker.io" |
There was a problem hiding this comment.
What about ghcr.io?
目前一直没有上传镜像到ghcr.io，且docker-pushrm目前只支持DockerHub、Quay、Harbor
There was a problem hiding this comment.
ghcr.io 抽空也加下吧，ghcr.io 展示的 README 我记得就是 repo 根目录的 README
There was a problem hiding this comment.
ghcr.io 抽空也加下吧，ghcr.io 展示的 README 我记得就是 repo 根目录的 README
docker-pushrm目前只支持DockerHub、Quay、Harbor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.