Skip to content

[MIRROR] [MIRROR] Ambience Buzz Handling Changes + Ambience buzz requires enviorment power [MDB IGNORE] #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ArkStation-Bot
Copy link
Collaborator

Original PR: NovaSector/NovaSector#3440

Original PR: tgstation/tgstation#84479

About The Pull Request

Partial port of DaedalusDock/daedalusdock#996

  • Fixes ambience prefrence inconsistancy issues with Observers unable to turn off the ambience buzz.
  • Ambience buzz requires a working, existing, charged APC with power to the enviorment.
  • Moves update_ambience_area() and refresh_looping_ambience() into code\controllers\subsystem\ambience.dm for better organization.

Why It's Good For The Game

Mostly to tackle a prefrence bug where ghosts are unable to turn off ambience buzz. But this also includes ambience buzz requiring a powered area. Makes the station feel more dead when there's no enviorment power. There should also be no buzzing inside space.

Changelog

🆑 Kapu (ported by StrangeWeirdKitten)
fix: Ambience buzz will now respect ship ambience prefrences for observers.
sound: Ambience buzz requires APC enviorment power to function
/:cl:

Copy link
Contributor

github-actions bot commented Jul 9, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Jul 9, 2024
@Krashly Krashly closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants