Skip to content

fix: Do not throw away playground stream when protocol error occurs #8393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cephalization
Copy link
Contributor

@cephalization cephalization commented Jul 2, 2025

Resolves #8177

Summary by Sourcery

Catch and suppress httpx.RemoteProtocolError in the chat_completion_create streaming loop to prevent dropping the playground stream on protocol errors

Bug Fixes:

  • Prevent stream termination on protocol errors in playground by adding a try/except around the streaming loop

Enhancements:

  • Log protocol errors temporarily to aid debugging of vllm streaming issues

@cephalization
Copy link
Contributor Author

I can't replicate the original issue with my own vllm setup, and changing this causing cascading test failures. I am inclined to close in favor of a potential UI side solution where we don't throw away stream contents when an error occurs later in the stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📘 Todo
Development

Successfully merging this pull request may close these issues.

[BUG]: Phoenix Playground Run Error Checking
1 participant