update OpenAI function_call to tool_call (#8015)

[sajozsattila]

Updated the OpenAI evaluation model. For details see #8015 bug

[github-actions]

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

Sajo Zsolt Attila seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request}

[anticorrelator]

Hi @sajozsattila thanks so much for the contribution!

In order to fully support this we also need to wire up tool_choice into llm_classify and run_evals. Specifically we need to modify the openai_function_call_kwargs function to pass in the new tool_choice kwarg into the model. Furthermore we should consider deprecating the use_function_calling_if_available kwarg in preference for the use_tool_calling_if_available keyword argument.

Please include an example that shows the modified behavior still works after the changes either as a small script in the PR description that can be replicated or a unit test as well

[anticorrelator]

I think we should leave the old kwarg around as well and raise a warning if users try to use it. I don't think this update is worth breaking backwards compatibility for

[sajozsattila]

fixed

[RogerHYang]

There's no substantive advantage in changing the name of parameters since "function calling" remains a valid terminology: I would recommend that we keep the old parameter instead.

[anticorrelator]

same as above

[sajozsattila]

fixed

[RogerHYang]

It's not necessary to rename function_call to tool_call everywhere, because "function calling" remains a valid terminology. The real change that's needed to revise the kwargs here, i.e. "functions" should now be "tools" and "function_call" should now be "tool_choice" with the value of {"type": "function", "function": {"name": openai_function["name"]}}.

[sajozsattila]

I made some changes, please check it. There is also a script to check. You need to set the OpenAI or Openrouter key to test.

phoenix_opeanai_tool_test.tgz

[RogerHYang]

replace this with the following

    return {
        "tools": [openai_function],
        "tool_choice": {"type": "function", "function": {"name": openai_function["name"]}},
    }

[RogerHYang]

Sajo Zsolt Attila seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@sajozsattila there seems to be an issue with mismatching emails associated with your commit. See message above. Are you able to fix?

[sajozsattila]

I am not moving forward with this pull request at the moment. I initially thought it was just a quick fix, but it seems I need to spend more time with the code than I currently have.

[RogerHYang]

@sajozsattila No worries, we can take over this PR and get it merged. Thanks for bringing this to our attention.

On the other hand, we would love to add you as a contributor. For that to work, would you be able to add your email to your Github account, so that you can accept the CLA as noted above?