Skip to content

XSD: Remove display attribute from fields #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hamishwillee
Copy link
Contributor

This removes the XSD to allow display="bitmask" on a field. We now expect the bitmask attribute to be set on the enum itself.

The trigger for this was the accidental reintroduction of the attribute in mavlink/mavlink#2289

My concern about this is that it might break other systems that aren't directly managed by MAVLink org.

@hamishwillee
Copy link
Contributor Author

@peterbarker This works upstream, but we need get rid of the last instances here.

But, the question stands, what about other dialects that don't talk to this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant