-
Notifications
You must be signed in to change notification settings - Fork 19.1k
HAL_ChibiOS: Added support for CORVON743V1 #29797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add the SD card support in the bootloader so flashing from SD is possible...also you would need to add this in the bootloader hwdeef:
define AP_BOOTLOADER_FLASH_FROM_SD_ENABLED 1
and this in the hwdef:
env BUILD_ABIN True
@@ -0,0 +1,11 @@ | |||
#BATTERY MONITOR ON | |||
BATT_MONITOR 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to hwdef
OSD_TYPE2 = 5 | ||
|
||
#Serial Port defaults | ||
SERIAL2_PROTOCOL 42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move all these to hwdef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mistakenly checked comment instead of request changes on my review...this tags as such
and your board id has already been taken....I suggest a separate PR to reserve (they geet merged quickly) and you will need to redo the bootloader file (you will anyway iff you follow my suggestion re SD card flashing_
sure, this PR for reserving the borad ID, I'll correct the rest docs, thanks. |
Hello, I have added define AP_BOOTLOADER_FLASH_FROM_SD_ENABLED 1 into hwdef-bl, but have problem while building the new bootloader.
|
dont know if you added the SD interface, but I discovered that some other defines in the bootloader hwdef are required...I need to add them to the wiki...here is what is needed your file: microSD supportPC12 SDMMC1_CK SDMMC1 FATFS support:define CH_CFG_USE_MEMCORE 1 it build for me now |
thanks, I'll try it out. |
@Hwurzburg Hello, I have updated the files, please review them when you get a chance, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close
@Hwurzburg thanks for your patience, hope it could work out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close,but not quite
I fixed everything, squashed, split and rebased....added devcall tag
thank you. |
No description provided.