Skip to content

HAL_ChibiOS: Added support for CORVON743V1 #29797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Conversation

holydust
Copy link
Contributor

No description provided.

@Hwurzburg Hwurzburg requested review from andyp1per and Hwurzburg May 5, 2025 20:52
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label May 5, 2025
Copy link
Contributor

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add the SD card support in the bootloader so flashing from SD is possible...also you would need to add this in the bootloader hwdeef:
define AP_BOOTLOADER_FLASH_FROM_SD_ENABLED 1
and this in the hwdef:
env BUILD_ABIN True

@@ -0,0 +1,11 @@
#BATTERY MONITOR ON
BATT_MONITOR 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to hwdef

OSD_TYPE2 = 5

#Serial Port defaults
SERIAL2_PROTOCOL 42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move all these to hwdef

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly checked comment instead of request changes on my review...this tags as such

and your board id has already been taken....I suggest a separate PR to reserve (they geet merged quickly) and you will need to redo the bootloader file (you will anyway iff you follow my suggestion re SD card flashing_

@holydust
Copy link
Contributor Author

I mistakenly checked comment instead of request changes on my review...this tags as such

and your board id has already been taken....I suggest a separate PR to reserve (they geet merged quickly) and you will need to redo the bootloader file (you will anyway iff you follow my suggestion re SD card flashing_

sure, this PR for reserving the borad ID, I'll correct the rest docs, thanks.

@holydust
Copy link
Contributor Author

you should add the SD card support in the bootloader so flashing from SD is possible...also you would need to add this in the bootloader hwdeef: define AP_BOOTLOADER_FLASH_FROM_SD_ENABLED 1 and this in the hwdef: env BUILD_ABIN True

Hello, I have added define AP_BOOTLOADER_FLASH_FROM_SD_ENABLED 1 into hwdef-bl, but have problem while building the new bootloader.

Build failed
-> task in 'bootloader/AP_Bootloader' failed (exit status 1):
{task 4452046816: cxx flash_from_sd.cpp -> flash_from_sd.cpp.7.o}

@Hwurzburg
Copy link
Contributor

dont know if you added the SD interface, but I discovered that some other defines in the bootloader hwdef are required...I need to add them to the wiki...here is what is needed your file:
define AP_BOOTLOADER_FLASH_FROM_SD_ENABLED 1
define FATFS_HAL_DEVICE SDCD1
define FATFS_HAL_DEVICE SDCD1

microSD support

PC12 SDMMC1_CK SDMMC1
PD2 SDMMC1_CMD SDMMC1
PC8 SDMMC1_D0 SDMMC1
PC9 SDMMC1_D1 SDMMC1
PC10 SDMMC1_D2 SDMMC1
PC11 SDMMC1_D3 SDMMC1

FATFS support:

define CH_CFG_USE_MEMCORE 1
define CH_CFG_USE_HEAP 1
define CH_CFG_USE_SEMAPHORES 0
define CH_CFG_USE_MUTEXES 1
define CH_CFG_USE_DYNAMIC 1
define CH_CFG_USE_WAITEXIT 1
define CH_CFG_USE_REGISTRY 1

it build for me now

@holydust
Copy link
Contributor Author

dont know if you added the SD interface, but I discovered that some other defines in the bootloader hwdef are required...I need to add them to the wiki...here is what is needed your file: define AP_BOOTLOADER_FLASH_FROM_SD_ENABLED 1 define FATFS_HAL_DEVICE SDCD1 define FATFS_HAL_DEVICE SDCD1

microSD support

PC12 SDMMC1_CK SDMMC1 PD2 SDMMC1_CMD SDMMC1 PC8 SDMMC1_D0 SDMMC1 PC9 SDMMC1_D1 SDMMC1 PC10 SDMMC1_D2 SDMMC1 PC11 SDMMC1_D3 SDMMC1

FATFS support:

define CH_CFG_USE_MEMCORE 1 define CH_CFG_USE_HEAP 1 define CH_CFG_USE_SEMAPHORES 0 define CH_CFG_USE_MUTEXES 1 define CH_CFG_USE_DYNAMIC 1 define CH_CFG_USE_WAITEXIT 1 define CH_CFG_USE_REGISTRY 1

it build for me now

thanks, I'll try it out.

@holydust
Copy link
Contributor Author

@Hwurzburg Hello, I have updated the files, please review them when you get a chance, thanks.

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close

@holydust holydust requested a review from Hwurzburg May 19, 2025 09:21
@holydust
Copy link
Contributor Author

@Hwurzburg thanks for your patience, hope it could work out.

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close,but not quite
I fixed everything, squashed, split and rebased....added devcall tag

@tridge tridge merged commit 30a7066 into ArduPilot:master May 19, 2025
51 checks passed
@holydust
Copy link
Contributor Author

close,but not quite I fixed everything, squashed, split and rebased....added devcall tag

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants