Skip to content

Sign error in ellipsoid height calculation #23613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
makeller1 opened this issue Apr 26, 2023 · 3 comments
Closed

Sign error in ellipsoid height calculation #23613

makeller1 opened this issue Apr 26, 2023 · 3 comments

Comments

@makeller1
Copy link
Contributor

makeller1 commented Apr 26, 2023

Bug report

Issue details
Seeing a sign error on how the ellipsoid height is calculated.
The undulation is subtracted from alt here
height_elipsoid_mm = loc.alt*10 - undulation*1000;

Which doesn't make sense considering the alt is calculated as height - undulation
state.location.alt = (int32_t)(((float)temp.Height - temp.Undulation) * 1e2f);

That would imply ellipsoid height = height - 2 * undulation.

@hendjoshsr71

Version
Master

Platform
[X] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

@rmackay9
Copy link
Contributor

This is probably one for @tridge, @hendjoshsr71 and/or @BluemarkInnovations to look into as the code was added in PR #21075

@makeller1
Copy link
Contributor Author

Addressed by PR #23942.

@tridge
Copy link
Contributor

tridge commented Jun 6, 2023

thanks! fixed with your PR

@tridge tridge closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants