ConfigRawParams: manual absolute column sizing #3194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does 2 things: 1. Makes all columns but Desc and Fav manually sizeable (no more autosizing) 2. Stores and retrieves column widths from config.xml in absolute widths instead of percentages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does 2 things:
It actually makes more sense for most columns to remain a fixed size for various window sizes, and let the Desc column fill to take up any extra space. This PR solves multiple issues, from the autosize not working correctly cross-platform, to the tendency for the FAV column to accidentally getting larger and larger with each restart. Once the user has tuned the widths to taste, they never have to touch it again.
I also tweaked the default widths to what I think are sensible values.