-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Param list improvements #3080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Param list improvements #3080
Conversation
the only thing to be mindfull of is Tree is not cross platform friendly. list is. |
although just knoticed you removed so it might be friendly now |
Yeah, the BrightIdeas tree control was being finnicky for me when I was trying to bring the tooltip changes over, and the documentation for it wasn't great, so I figured it was time to try an overhaul using built-in types. Should be cross-platform friendly. I can only test Windows, Android and Linux though. |
@meee1, any idea why I'm getting this issue on the Android build?
I can't imagine that's related to this PR. |
fixed, cleared the build cache |
Reworked tooltip display for better viewing of now-hidden text
This also fixes the "favorites" feature, as well as a little-known feature that opens urls in descriptions when clicked. These broke the when the "default" column was added.
Also, driveby fix to ParameterMetaDataRepository, floats mixed in here were causing rounding errors leading to errant warnings about being out of bounds.
0319eb1
to
8a84275
Compare
The really tall rows caused by long value descriptions makes the full param list hard to look at. Additionally, the cells causing this weren't particularly easy to read. Instead of auto-fitting the row height, I have opted to improve the look of the tooltip for overflowing cells. It is now significantly more readable.
While I was trying to bring some of those improvements over to the Full Parameter Tree view, I decided to overhaul it to make the two pages consistent. I think it looks and works much better to have a tree view separated in a split pane from the grid view. I'm pretty happy with how it turned out, and it could easily be combined into a single page instead of being offered as two separate options.