Bringing my base up to date #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some websites (eg. imgur.com) don't have OGP tags but they do indicated an image associated with the page using image_src. Facebook's oEmbed falls back on this if OGP data isn't avalable.
- Replace file_get_contents() with Curl because Curl is faster and file_get_contents() is disabled on a lot of servers for security reasons. - I also notice Curl getting a lot of results back from websites where file_get_contents() didn't work.
…ontents-with-curl Replace file_get_contents() with cURL for speed/security
Added to retrieve using value attribute, fallback.
- Fix DOMDocument::loadHTML() throwing a PHP Warning if the result of the cURL call is an empty string. Checks that the result of the curl call isn't empty before passing it to _parse() function.
…TML-empty-string-warning Fix DOMDocument Empty String PHP Warning
Fallback to use image_src if ogp::image isn't set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.