-
-
Notifications
You must be signed in to change notification settings - Fork 223
chore(android): support react-native 0.79.0 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this backwards compatible? |
I think the problem with this approach is that we lose support for all props implemented in Seems like this no longer works in 0.79. I had a look and it seems that it now uses a check on an interface to know if the class will implement the delegate. Could you try removing the RNCSafeAreaViewManagerInterface interface and see if it works? |
You are right, working fine. Tested on RN 74 as it is minimal supporter for v5, on example and on 0.79.0. All of them behave as expected. I will not be available until start of next week in case there is something I have missed and changes required :( I could take a look after, or someone to update in the meantime, sorry |
if you want to fix it you can use this import React from 'react'; export const SafeView = ({ children, style }) => { const top = typeof insets.top === 'number' ? insets.top : 0; return ( export default SafeView; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great on RN 0.79.0, please merge.
Thanks a lot @akuul, will get this merged today |
@janicduplessis this is happening to me when adding the SafeAreaProvider on the top level: import React from 'react';
import {SafeAreaProvider} from 'react-native-safe-area-context';
import {SafeAreaView, Text, StyleSheet, View} from 'react-native';
const App = () => {
return (
// <SafeAreaView style={styles.container}>
<SafeAreaProvider>
<View style={styles.container}>
<Text style={styles.title}>Welcome to App</Text>
<Text style={styles.subtitle}>
Your production-ready React Native project is set up!
</Text>
</View>
</SafeAreaProvider>
);
};
} This only happens on android: {
"name": "App",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"lint": "eslint .",
"start": "react-native start",
"test": "jest"
},
"dependencies": {
"@react-navigation/elements": "2.3.8",
"@react-navigation/native": "7.1.6",
"@react-navigation/native-stack": "7.3.10",
"react": "19.0.0",
"react-native": "0.79.1",
"react-native-safe-area-context": "5.4.0",
"react-native-screens": "4.10.0"
},
"devDependencies": {
"@babel/core": "^7.25.2",
"@babel/preset-env": "^7.25.3",
"@babel/runtime": "^7.25.0",
"@react-native-community/cli": "18.0.0",
"@react-native-community/cli-platform-android": "18.0.0",
"@react-native-community/cli-platform-ios": "18.0.0",
"@react-native/babel-preset": "0.79.1",
"@react-native/eslint-config": "0.79.1",
"@react-native/metro-config": "0.79.1",
"@react-native/typescript-config": "0.79.1",
"@types/jest": "^29.5.13",
"@types/react": "^19.0.0",
"@types/react-test-renderer": "^19.0.0",
"eslint": "^8.19.0",
"jest": "^29.6.3",
"prettier": "2.8.8",
"react-test-renderer": "19.0.0",
"typescript": "5.0.4"
},
"engines": {
"node": ">=18"
}
}
This is a brand new app, created minutes before adding react native safe area context |
# Why Pull in AppAndFlow/react-native-safe-area-context#610 --------- Co-authored-by: Expo Bot <[email protected]>
I'd like to know when are we getting a release with these changes? |
I'm in [email protected], and RN v79.2 getting the same error. I used the custom one but it's not that good, please fix the issue ASAP |
@janicduplessis I am, as others as well, still experiencing this error with v5.4.0 and RN v0.79. |
The current expo go on android causes this problem. You can install it from here ---> https://expo.dev/go Hopefully it will solve the problem 👍 |
using the latest one, but didn't worked, so i used my custom SafeAreaViw using the
|
I am using Expo Go 2.33.16 for Expo SDK 53 with RN v0.79 and v5.4.0 of react-native-safe-area-context which are the latest versions and I'm still experiencing the issue. As a current workaround I'm using a custom SafeArea with |
You need Expo Go 2.33.19 |
Expo Go Update just popped up in Play Store, i can confirm it does work with Expo Go 2.33.19 👍 |
yep! Expo Go 2.33.19 has the fix, migrating to again react-native-safe-area-context |
still happening for dev-client builds |
Also experiencing this for my android dev-client builds |
also seeing this in dev-client builds |
any fix for android ??? |
Summary
Release of React Native 0.79 broke Android builds that resulted in an error:
Exception thrown when executing UIFrameGuarded Attempt to invoke interface method 'void com.facebook.react.uimanager.ViewManagerDelegate.setProperty(android.view.View, java.lang.String, java.lang.Object)' on a null object reference
Tested on React Native 0.76.1 example and React Native 0.79.0
Closes #607
Test Plan