Skip to content

update license text (arbitrary change so that we can do a new release) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2022

Conversation

lukaskollmer
Copy link
Member

see title

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #2 (49418d9) into develop (7de65b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop       #2   +/-   ##
========================================
  Coverage    77.78%   77.78%           
========================================
  Files            6        6           
  Lines           81       81           
========================================
  Hits            63       63           
  Misses          18       18           
Impacted Files Coverage Δ
Sources/ApodiniDocumentExport/ExportOptions.swift 0.00% <ø> (ø)
...cumentExport/Extensions/Decodable+Extensions.swift 100.00% <ø> (ø)
...cumentExport/Extensions/Encodable+Extensions.swift 100.00% <ø> (ø)
...iDocumentExport/Extensions/String+Extensions.swift 100.00% <ø> (ø)
Sources/ApodiniDocumentExport/FileExtension.swift 78.58% <ø> (ø)
Sources/ApodiniDocumentExport/OutputFormat.swift 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de65b4...49418d9. Read the comment docs.

@lukaskollmer
Copy link
Member Author

@PSchmiedmayer idk what exactly is the issue here, but for some reason SPM will always pick some weird commit which doesn't belong to any branch, instead of simply using the commit associated with the 0.1.1 tag. I had tried to work around this in the past by simply hardcoding the correct commit hash into Apodini's Package.swift file, which actually worked fine for a while, but now seems to have broken.
The idea here is to try to create a new release and hope that SPM will pick that up correctly, so that we don't have to specify the explicit hash in the package file anymore.

@PSchmiedmayer PSchmiedmayer merged commit 0843042 into develop Dec 18, 2022
@PSchmiedmayer
Copy link
Contributor

@lukaskollmer Thank you, that sounds like a good idea. I have merged the PR and will tag a new release 👍

@PSchmiedmayer PSchmiedmayer deleted the lukaskollmer/fix-maybe branch December 18, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants