Skip to content

Update Runtime framework with latest fix #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2021
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jul 1, 2021

Update Runtime framework with latest fix

♻️ Current situation & Problem

The Runtime framework still had some problems with createInstance() on linux platforms when called for class types (see wickwirew/Runtime#49).
A fix for this is currently being developed wickwirew/Runtime#95.

💡 Proposed solution

This PR adds the latest version of my fork to the Package.swift, containing the linked PR.

➕ Additional Information

This issue currently has no impact on the main Apodini project or Apodini users.
But it may affect @eldcn approach of the new TypeInformation package.

This PR also adjust some small things in the NegativeTestRunner due to #294.

Related PRs

The forked version of Runtime was already incorporated in #294

Testing

--

Reviewer Nudging

--

@Supereg Supereg requested review from a team, theMomax and hendesi and removed request for a team July 1, 2021 14:20
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #308 (fbface0) into develop (a0fa59a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #308   +/-   ##
========================================
  Coverage    80.64%   80.64%           
========================================
  Files          301      301           
  Lines        11331    11331           
========================================
  Hits          9137     9137           
  Misses        2194     2194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fa59a...fbface0. Read the comment docs.

Copy link
Contributor

@hendesi hendesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Maybe let @eldcn check for any implications on his side, before merging it.

@eldcn
Copy link

eldcn commented Jul 4, 2021

Thanks for fixing the issue. I have also experienced problems in linux due to Runtime in my package. It is also fine for me, I can simply start tracking your fork 👍

@Supereg
Copy link
Member Author

Supereg commented Jul 4, 2021

@eldcn yes. Currently there are two Linux specific problems fixed in my branch. For one an issue with typeInfo for class types for >= swift 5.4 and the one presented here.

Feel free to share any issue you still encounter in your project (the fork has some extensive unit testing for Linux platform should you need it). Maybe I’m able to tackle those as well, but in any case we can at least contribute some test vectors back to the upstream.

@Supereg Supereg merged commit faace8e into develop Jul 4, 2021
@Supereg Supereg deleted the fix/update-runtime branch July 4, 2021 12:06
eldcn pushed a commit that referenced this pull request Jul 6, 2021
…ture/migrator

* 'develop' of https://github.com/Apodini/Apodini:
  Rework Exporter API (#307)
  Rework ContextNode infrastructure to accommodate for extended requirements (#303)
  Update Runtime framework with latest fix (#308)
  AWS resource management, and other improvements (#293)
  Update Package to Swift 5.4 (#294)
  Update dependencies (#305)
  Update spm-update.yml (#306)
  Adapt swift-argument-parser dependency version and strategy (#304)
  Add DOI to README
  Quickfix: Make Response.information settable
  Renew ExporterConfiguration and CLI arguments of the WebService (#292)
  Remove Relationship Code from `SemanticModelBuilder` (#299)
  Fix Propagation of Delegate Optionality (#302)

# Conflicts:
#	Package.swift
#	TestWebService/Sources/TestWebService/TestWebService.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants