Skip to content

Upgrade to Bootstrap v4.6.2 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Apr 30, 2023

Changes

  • Fixes warning: Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
  • Moved bootstrap customization to _variables.scss
  • Update bootstrap to latest v4 version
  • Update jQuery to latest version

Reference

Preparation for migration to v5 #203

@Rotzbua Rotzbua force-pushed the upgrade_bootstrap branch from 0fe5d32 to 848c35d Compare April 30, 2023 13:36
@ByteHamster
Copy link
Member

Can't we just switch directly to 5.0 instead of taking two individual steps?

@Rotzbua
Copy link
Contributor Author

Rotzbua commented May 5, 2023

I am not a fan of a mayor version migration with skipping subversions. Because then it is difficult to find the source of a problem.
Migration to bootstrap 5 does require some refactoring. This pr is just library update without any code change but fixes the sass warnings.

Copy link
Member

@keunes keunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we need to make some minor changes. But otherwise: let's merge :-)

@Rotzbua Rotzbua force-pushed the upgrade_bootstrap branch from b7b975f to 8d59b60 Compare May 7, 2023 17:11
@Rotzbua Rotzbua requested a review from keunes May 7, 2023 17:18
@Rotzbua Rotzbua mentioned this pull request May 7, 2023
5 tasks
@Rotzbua Rotzbua force-pushed the upgrade_bootstrap branch 2 times, most recently from 120339e to 0a238b6 Compare May 9, 2023 14:13
@Rotzbua Rotzbua force-pushed the upgrade_bootstrap branch from 0a238b6 to 7770917 Compare May 12, 2023 14:09
@keunes keunes merged commit 12eafcd into AntennaPod:master Jul 3, 2023
@keunes
Copy link
Member

keunes commented Jul 3, 2023

Thanks again :-)

@Rotzbua Rotzbua deleted the upgrade_bootstrap branch July 3, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants