Fix theme logic #93
Merged
Fix theme logic #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/MonsterUI/pull/93 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR to address theme loading issues. Currently when changing the theme via the modal, it saves to localStorage correctly but both the
defaulttheme and the localStorage preference are added to the html tag. This is causing conflicts where certain themes are overriding others.Removing the additional
htmlElement.classList.add("uk-theme-{color}");snippet ensures the theme matches the option set in storage, or uses to the default if none is set. This is how it's documented in FrankenUI, so I'm guessing it was added on purpose - let me know the functionality you were aiming for and we can try to find another solution!