Skip to content

Update component classes to align with Franken UI v2.0 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Zaseem-BIsquared
Copy link
Contributor

@Zaseem-BIsquared Zaseem-BIsquared commented Feb 12, 2025

Issue

Some of the components are using old classes and need to be updated based on Franken UI v2.0

Changes Made

  • Updated ContainerT, CardT, and TableT class names to match the documented patterns from Franken UI v2.0 docs

References

Testing

  • Tested locally to confirm everything was working properly
  • Verified class names match documentation specifications

Copy link

gitnotebooks bot commented Feb 12, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/MonsterUI/pull/67

@Zaseem-BIsquared
Copy link
Contributor Author

Zaseem-BIsquared commented Feb 12, 2025

Hey! Isaac, Just noticed uk-card-default class (used in CardT.default) is removed in v2.0. Not sure if we should remove it since other components might break. What do you think? Here's the Card Docs for reference 🤔

@Isaac-Flath
Copy link
Collaborator

Wow thank you so much for catching this!

@Isaac-Flath Isaac-Flath added the bug Something isn't working label Feb 12, 2025
@Isaac-Flath Isaac-Flath merged commit 417e0dd into AnswerDotAI:main Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants