Skip to content

Apex Charts support #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 27, 2025
Merged

Apex Charts support #110

merged 8 commits into from
May 27, 2025

Conversation

ndendic
Copy link
Contributor

@ndendic ndendic commented May 24, 2025 •
edited by comhar
Loading

This pr adds support for Apex Charts #112

ndendic and others added 4 commits May 21, 2025 18:50
@ndendic
Add Apex Chart examples and update API references
6ef7507
@ndendic
Updated documentaion with some details on examples.
b612c48
@ndendic @comhar
Update core.py param name and default settings
64a067c 
Co-authored-by: Tommy <[email protected]>
@ndendic
Refactor Apex chart implementation and update headers
4c93aa4 
- Changed `Apex_Chart` to `ApexChart` for consistency.
- Introduced `apex_json_formater` function to construct Apex chart JSON.
- Updated header methods to include `apex_charts` parameter.
- Added `uv.lock` to `.gitignore` to prevent tracking of lock files.
@gitnotebooks GitNotebooks
Copy link

gitnotebooks bot commented May 24, 2025

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/MonsterUI/pull/110

@ndendic ndendic changed the title Feature/apex charts recovery Apex Charts support May 24, 2025
@ndendic
Copy link
Contributor Author

ndendic commented May 24, 2025

@ohmeow This is the continuation on the previous PR that I've accidentally closed.
I've made the updates that you proposed. I've modified original component into a json formatter/helper function - if you feel it's overkill, feel free to remove it.
Please also check out new proposed docs page, and let me know if it makes sense.

@comhar comhar self-assigned this May 26, 2025
@comhar comhar self-requested a review May 26, 2025 12:47
@comhar comhar added the enhancement New feature or request label May 26, 2025
@comhar
Copy link
Contributor

comhar commented May 26, 2025

@ohmeow This is the continuation on the previous PR that I've accidentally closed. I've made the updates that you proposed. I've modified original component into a json formatter/helper function - if you feel it's overkill, feel free to remove it. Please also check out new proposed docs page, and let me know if it makes sense.

Thanks @ndendic. I pushed a couple of changes in the most recent commit (removed the json formatter, simplified the docs, and added some examples to the notebook). If you're happy with these changes then I'll go ahead and merge.

@comhar comhar removed their request for review May 26, 2025 12:50
@ndendic
Copy link
Contributor Author

ndendic commented May 26, 2025

@comhar Thanks for fast review, I'm good with all of those. Thank you!

@comhar comhar merged commit 144ff5d into AnswerDotAI:main May 27, 2025
@comhar comhar mentioned this pull request May 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@comhar comhar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndendic @comhar