Globe Lighting #1251
Merged
Globe Lighting #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: CHANGES.md
| @@ -227,6 +254,12 @@ define([ | |||
| }, | |||
| u_oceanNormalMap : function() { | |||
| return that._oceanNormalMap; | |||
| }, | |||
| u_lightingFadeOutDistance : function() { | |||
There was a problem hiding this comment.
Make these a single vec2 uniform. Setting individual uniforms - especially for this particle shader - is one of our bottlenecks.
|
Can we add a simple rendering test for when |
|
The difference between the fade distances is a little quick for me, but it's up to you. Consider using |
|
@pjcozzi This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds temporary globe lighting that is disabled by default.
@emackey Feel free to make any tweaks that you think could make it look better.