Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devcontainer support #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devcontainer support #709
Changes from 5 commits
34b3505
4243599
092d756
0bb24e4
ae1cf2a
5ccb7da
177be2d
7738274
8af8b91
f80f85d
36d5a7b
010c674
beb5103
9474397
73f6d13
26b3d55
52d822d
d3979d1
f83d720
129903c
cfbc2aa
3dfec6d
68625ec
7d8d0d0
71e314c
2a0dcff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this should be fine we should verify the site runs fine on the latest Hugo version (
v0.139.4
) as we currently pin the production site to0.98.0
. This was done at the time to ensure no surprise breakages between versions.Similar with Python--we pin version
3.11
, however we should be able to use the3.12
in repositories (or we could pin3.9
to match the devcontainer).Ultimately I'd like to have a 1:1 environment with our production, so we have two options:
I'm thinking option 2 is the move as I'm pretty sure most people working on the site aren't using an ancient version of Hugo..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a note: I'm not sure the pinning you mentioned is actually working as intended. I recently (maybe as many as a few months ago) hit some snags due to outdated hugo installed on my laptop. I had to upgrade so that what I was doing would match the errors I was seeing as it deployed to dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're correct @bennyvasquez. The latest run I can see in GitHub actions uses the latest version 0.140.0
https://github.com/AlmaLinux/almalinux.org/actions/runs/12401185107/job/34620009233