Skip to content

Total time and action timestamps #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 4, 2025
Merged

Conversation

juanmichelini
Copy link
Collaborator

Added a total time (duration) field to each instance.
Added timestamps to each action.

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trajectory-visualizer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 0:07am

@neubig
Copy link
Contributor

neubig commented Apr 16, 2025

@OpenHands please check the github actions and fix any failing ones. monitor github actions until all of them other than vercel pass, then push an empty commit with "[email protected]" as the author to trigger vercel deployment.

Copy link

openhands-ai bot commented Apr 16, 2025

I'm on it! @neubig can track my progress at all-hands.dev

Copy link

openhands-ai bot commented Apr 17, 2025

Work Summary

I successfully addressed the GitHub Actions failures in PR #16 of the trajectory-visualizer repository. Here's what I did:

  1. Identified the Issue:

    • Found a TypeScript error in the JsonlViewer.tsx component related to timestamp handling
    • The error occurred because the code wasn't properly handling potentially undefined timestamp values
  2. Fixed the Code:

    • Modified the timestamp handling in the calculateDurationMs function
    • Added fallback values using the || operator to handle undefined timestamps
    • Fixed: new Date(history[0].timestamp || new Date()) instead of new Date(history[0].timestamp)
  3. Verified the Fix:

    • Ran the build locally to confirm the fix worked
    • Committed and pushed the changes to the PR branch
  4. Monitored GitHub Actions:

    • Tracked the GitHub Actions workflow runs until all checks passed
    • Confirmed that test, build (18.x), and build (20.x) checks all succeeded
  5. Triggered Vercel Deployment:

    • As requested, pushed an empty commit with "[email protected]" as the author
    • Monitored the checks again to ensure they all passed

The PR is now in a clean, mergeable state with all GitHub Actions checks passing successfully. The Vercel deployment should now be triggered as requested.

@neubig neubig self-assigned this May 22, 2025
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@neubig neubig merged commit e9e911c into main Jun 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants