Skip to content

refactor(frontend): Make the secrets table styling consistent. #9628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

hieptl
Copy link
Contributor

@hieptl hieptl commented Jul 9, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.

🔍 Description

The visual styling of the Secrets table differs from that of the API Keys table, leading to inconsistency in the UI. Aligning their design will improve overall cohesiveness and user experience.

The Secrets table currently uses a different styling approach compared to the API Keys table, which creates a visual mismatch across similar components.


✅ Expected Behavior

  • The Secrets table should follow the same styling as the API Keys table to maintain UI consistency.

❌ Current Behavior

  • The Secrets table uses inconsistent styling compared to the API Keys table.

🔁 Steps to Reproduce

  1. Navigate to the Secrets settings page.
  2. Observe the table layout and styling.
  3. Compare it to the API Keys table on its respective settings page.

📹 Additional Context

A video demonstrating the issue is available below:

issue.mov

Summarize what the PR does, explaining any non-trivial design decisions.

  • Update the Secrets table to match the visual style and layout of the API Keys table (e.g., typography, spacing, border styles, icons, etc.).

  • A video demonstrating the output is available below:

output.mov

Link of any specific issues this addresses:

Resolves #9627

@hieptl hieptl requested review from rbren and amanape as code owners July 9, 2025 05:45
@amanape amanape self-assigned this Jul 9, 2025
@Abubakar-01
Copy link

✅ Verified the PR. The UI for the Secrets section has been updated to exactly match the requirements mentioned in the issue. However, I don’t see the API Keys tab in the Settings section in either the main branch or this PR branch. Mentioning this because the Secrets UI was updated to align with the API Keys UI for consistency, but the API Keys section itself is currently missing.

image

@hieptl
Copy link
Contributor Author

hieptl commented Jul 10, 2025

Hi @Abubakar-01

Thank you for your comment!

Let me know if you have any questions!

Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@amanape amanape merged commit 8cb1c73 into All-Hands-AI:main Jul 10, 2025
17 checks passed
VasilisAvgoustakis pushed a commit to VasilisAvgoustakis/OpenHands that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the secrets table styling consistent.
3 participants