Skip to content

Enhanced llm editor #9174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Enhanced llm editor #9174

wants to merge 9 commits into from

Conversation

mindflow-cn
Copy link

@mindflow-cn mindflow-cn commented Jun 17, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.

When enable_auto_lint=true is set, the accuracy of code modification in llm editor is enhanced


Summarize what the PR does, explaining any non-trivial design decisions.

I modified edit.py to enhance this feature:

  • When enable_auto_lint=true, if any lint error occurs, I also write the code to the file
  • I added the correct_num configuration in config.toml so that llm can make several attempts when an error occurs, thus ensuring that FileEditAction is as correct as possible
  • Added the ability to configure resources based on gpu id

Link of any specific issues this addresses:

#9173

@enyst enyst requested a review from xingyaoww June 19, 2025 12:14
@mindflow-cn
Copy link
Author

I have completed the modification

Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall seems good to me!

Only concern now is that it changes the existing prompt which @leandermaben is running experiments on. Would appreciate a quick 👀 from @leandermaben .

An alternative way to get this merge faster would be keep the USER_MSG unchanged, and just add the CORRECT_SYS_MSG

@mindflow-cn
Copy link
Author

Thanks! Overall seems good to me!

Only concern now is that it changes the existing prompt which @leandermaben is running experiments on. Would appreciate a quick 👀 from @leandermaben .

An alternative way to get this merge faster would be keep the USER_MSG unchanged, and just add the CORRECT_SYS_MSG

OK, I have completed the modification. Please review it again. keep the USER_MSG unchanged, and just add the CORRECT_SYS_MSG

@leandermaben
Copy link
Contributor

Thanks! Overall seems good to me!
Only concern now is that it changes the existing prompt which @leandermaben is running experiments on. Would appreciate a quick 👀 from @leandermaben .
An alternative way to get this merge faster would be keep the USER_MSG unchanged, and just add the CORRECT_SYS_MSG

OK, I have completed the modification. Please review it again. keep the USER_MSG unchanged, and just add the CORRECT_SYS_MSG

Thanks for the updates. I will review it by evening today, apologies for the delay.

@mindflow-cn
Copy link
Author

Thanks! Overall seems good to me!
Only concern now is that it changes the existing prompt which @leandermaben is running experiments on. Would appreciate a quick 👀 from @leandermaben .
An alternative way to get this merge faster would be keep the USER_MSG unchanged, and just add the CORRECT_SYS_MSG

OK, I have completed the modification. Please review it again. keep the USER_MSG unchanged, and just add the CORRECT_SYS_MSG

Thanks for the updates. I will review it by evening today, apologies for the delay.

Thanks 😃😃😃

@neubig neubig added the needs-review The PR author would like someone to review. label Jun 23, 2025
@mindflow-cn
Copy link
Author

@leandermaben There is a conflict, Need me to resolve it?

@leandermaben
Copy link
Contributor

@leandermaben There is a conflict, Need me to resolve it?

Sure, that would be great!

@mindflow-cn
Copy link
Author

@leandermaben There is a conflict, Need me to resolve it?

Sure, that would be great!

I have completed

@mindflow-cn mindflow-cn requested a review from xingyaoww June 24, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR author would like someone to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants