Skip to content

Fix for nested runtimes still using the relative url #8947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Jun 6, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.
When using nested runtimes, we were not updating the active conversation when the status changed, resulting in the url still being null, and defaulting to /conversations/{conversation_id} rather than the actual url


Summarize what the PR does, explaining any non-trivial design decisions.

I also removed a flaky test - before yesterday it had mocks in there and tested our code - but with the MCP migration it...

  • Does not actually test our code (Since the timeout function is in the dependency)
  • Uses external network (So is not really a unit test)
  • Is flaky.

Link of any specific issues this addresses:


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:bfd13f5-nikolaik   --name openhands-app-bfd13f5   docker.all-hands.dev/all-hands-ai/openhands:bfd13f5

@tofarr tofarr marked this pull request as ready for review June 6, 2025 14:46
@tofarr tofarr requested review from rbren and amanape as code owners June 6, 2025 14:46
Copy link

openhands-ai bot commented Jun 6, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Run Python Unit Tests

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #8947

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

Copy link
Contributor

@malhotra5 malhotra5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tofarr tofarr enabled auto-merge (squash) June 6, 2025 15:36
@tofarr tofarr merged commit fac0d59 into main Jun 6, 2025
21 checks passed
@tofarr tofarr deleted the fix-nested-url-update branch June 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants