Fix for nested runtimes still using the relative url #8947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality this introduces.
When using nested runtimes, we were not updating the active conversation when the status changed, resulting in the url still being
null
, and defaulting to/conversations/{conversation_id}
rather than the actual urlSummarize what the PR does, explaining any non-trivial design decisions.
I also removed a flaky test - before yesterday it had mocks in there and tested our code - but with the MCP migration it...
Link of any specific issues this addresses:
To run this PR locally, use the following command: