Skip to content

chore(dependency): Update opentelemetry-api to resolve conflict with langfuse #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Jun 5, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.
This update resolves a dependency conflict that prevented OpenHands from being used alongside langfuse, a popular observability tool. Users can now install and use both OpenHands and langfuse in the same project without dependency conflicts.


Summarize what the PR does, explaining any non-trivial design decisions.
This PR updates the opentelemetry-api dependency from 1.25.0 to ^1.33.1 and protobuf from ^4.21.6,<5.0.0 to ^5.0.0,<6.0.0 to resolve a dependency conflict with langfuse.

The problem was that:

  • OpenHands depends on opentelemetry-api 1.25.0
  • langfuse depends on opentelemetry-api >=1.33.1,<2.0.0
  • Newer versions of opentelemetry require protobuf >=5.0, but OpenHands had a constraint of <5.0.0

Changes made:

  1. Updated opentelemetry-api from 1.25.0 to ^1.33.1
  2. Updated opentelemetry-exporter-otlp-proto-grpc from 1.25.0 to ^1.33.1
  3. Updated protobuf constraint from ^4.21.6,<5.0.0 to ^5.0.0,<6.0.0

Testing:
Created a test project that depends on both OpenHands and langfuse, and verified that they can be installed together without conflicts.

Note: The comment on the protobuf constraint mentioned that "chromadb currently fails on 5.0+", but chromadb is not used in the codebase, so this constraint was safely updated.


Link of any specific issues this addresses:
N/A


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:7e88013-nikolaik   --name openhands-app-7e88013   docker.all-hands.dev/all-hands-ai/openhands:7e88013

@xingyaoww
Copy link
Collaborator Author

@OpenHands pls make sure this PR's description follows the PR template of this repo

Copy link

openhands-ai bot commented Jun 5, 2025

I'm on it! xingyaoww can track my progress at all-hands.dev

Copy link

openhands-ai bot commented Jun 5, 2025

I successfully updated the PR description for PR #8930 to follow the repository's PR template format.

Here's what I did:

  1. Examined the PR template from .github/pull_request_template.md to understand the required format
  2. Compared it with the current PR description to identify what needed to be changed
  3. Created a new PR description that follows the template format while preserving all the valuable information from the original description
  4. Updated the PR description directly using the GitHub CLI (gh pr edit)

The updated PR description now includes:

  • The required checkboxes at the top (including marking that this change should be included in Release Notes)
  • An end-user friendly description section explaining how this resolves a dependency conflict with langfuse
  • A detailed summary of what the PR does, including the specific dependency updates and design decisions
  • A section for linking to specific issues (marked as N/A since there are no linked issues)

The PR description now properly follows the repository's template format while maintaining all the important technical details from the original description.

@xingyaoww xingyaoww changed the title Update opentelemetry-api to resolve conflict with langfuse chore(dependency): Update opentelemetry-api to resolve conflict with langfuse Jun 5, 2025
@xingyaoww xingyaoww marked this pull request as ready for review June 5, 2025 19:31
@xingyaoww xingyaoww enabled auto-merge (squash) June 5, 2025 19:55
@xingyaoww xingyaoww merged commit 959268b into main Jun 5, 2025
19 checks passed
@xingyaoww xingyaoww deleted the update-opentelemetry-dependencies branch June 5, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants