Skip to content

fix: make setup.sh executable for devcontainer postCreateCommand #8891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

llamantino
Copy link
Contributor

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.

Fixes an issue where .devcontainer/setup.sh is not executable (+x), causing the postCreateCommand to fail with Permission denied when starting the dev container in VS Code or GitHub Codespaces.

Log from vscode:

[12906 ms] Start: Run in container: /bin/sh -c .devcontainer/setup.sh
/bin/sh: 1: .devcontainer/setup.sh: Permission denied
[13016 ms] postCreateCommand from devcontainer.json failed with exit code 126. Skipping any further user-provided commands.

Log from Codespaces:

2025-06-04 15:37:17.425Z: Error: Command failed: /bin/sh -c .devcontainer/setup.sh
2025-06-04 15:37:17.425Z: {"outcome":"error","message":"Command failed: /bin/sh -c .devcontainer/setup.sh","description":"postCreateCommand from devcontainer.json failed.","containerId":""}


Summarize what the PR does, explaining any non-trivial design decisions.

This PR adds the executable permission (+x) to .devcontainer/setup.sh.


Link of any specific issues this addresses:

@neubig neubig merged commit ebacd1b into All-Hands-AI:main Jun 6, 2025
18 checks passed
@llamantino llamantino deleted the dev-container-setup-fix branch June 7, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants