-
Notifications
You must be signed in to change notification settings - Fork 7k
[Feat]: support streamable http mcp #8864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…econds to ClientSession
I have fixed the failing tests by updating the test files to match the new MCP client implementation that supports both SSE and StreamableHTTP protocols. The changes include:
All tests are now passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
openhands/core/main.py
Outdated
# FIXME: OpenHands' streamable http server may not be running when headless mode is started | ||
# if openhands_mcp_server: | ||
# config.mcp.sse_servers.append(openhands_mcp_server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# FIXME: OpenHands' streamable http server may not be running when headless mode is started | |
# if openhands_mcp_server: | |
# config.mcp.sse_servers.append(openhands_mcp_server) |
openhands/cli/main.py
Outdated
# FIXME: OpenHands' streamable http server may not be running when CLI mode is started | ||
# if openhands_mcp_server: | ||
# config.mcp.sse_servers.append(openhands_mcp_server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove it :D
# FIXME: OpenHands' streamable http server may not be running when CLI mode is started | |
# if openhands_mcp_server: | |
# config.mcp.sse_servers.append(openhands_mcp_server) |
End-user friendly description of the problem this fixes or functionality this introduces.
Summarize what the PR does, explaining any non-trivial design decisions.
Link of any specific issues this addresses:
To run this PR locally, use the following command: