Skip to content

Add detailed logging to remote runtime resume process #8819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented May 30, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.

Improved logging for remote runtime resume operations to help diagnose issues when paused runtimes fail to resume properly.


Summarize what the PR does, explaining any non-trivial design decisions.

This PR adds detailed logging to the remote runtime resume process to help diagnose issues when we fail to call /resume on a paused runtime. The changes include:

  1. Added info logs to track the code path through _start_or_attach_to_runtime
  2. Added detailed logging in _check_existing_runtime to track runtime status and resume attempts
  3. Added comprehensive try/except blocks with logging in _resume_runtime to capture any failures during the resume process
  4. Added detailed logging in the 503 response handler where we attempt to resume paused runtimes
  5. Removed redundant prefix from log messages since this information is already included in the log extras

Link of any specific issues this addresses:


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:cff7207-nikolaik   --name openhands-app-cff7207   docker.all-hands.dev/all-hands-ai/openhands:cff7207

@rbren rbren marked this pull request as draft May 30, 2025 20:27
@rbren rbren marked this pull request as ready for review May 30, 2025 20:28
@rbren rbren merged commit 21af525 into main Jun 2, 2025
18 checks passed
@rbren rbren deleted the add-logging-to-remote-runtime-resume branch June 2, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants