Fix flaky test_command_output_continuation test in BashSession #8813
+64
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality this introduces.
Fixes a flaky test in the BashSession class that was intermittently failing due to timing issues.
Summarize what the PR does, explaining any non-trivial design decisions.
This PR modifies the
test_command_output_continuation
test to be more robust against timing issues. The test was failing because it expected specific output patterns that could vary depending on execution timing.The updated test now:
This makes the test more reliable while still verifying the core functionality of command output continuation.
Link of any specific issues this addresses:
No specific issue, but this addresses a flaky test that was recently introduced.
To run this PR locally, use the following command: