Skip to content

Fix KeyError on router error logging #8769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Conversation

neubig
Copy link
Contributor

@neubig neubig commented May 28, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.

We were seeing this error in logs:

  File "/app/openhands/runtime/impl/action_execution/action_execution_client.py", line 407, in get_mcp_config
    if result['router_error_log']:
       ~~~~~~^^^^^^^^^^^^^^^^^^^^

This patch should fix it.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:d1c1eee-nikolaik   --name openhands-app-d1c1eee   docker.all-hands.dev/all-hands-ai/openhands:d1c1eee

We were seeing this error in logs:

```
  File "/app/openhands/runtime/impl/action_execution/action_execution_client.py", line 407, in get_mcp_config
    if result['router_error_log']:
       ~~~~~~^^^^^^^^^^^^^^^^^^^^
```

This patch should fix it.
@neubig neubig requested review from xingyaoww and mamoodi May 28, 2025 19:45
@neubig neubig enabled auto-merge (squash) May 28, 2025 19:46
@neubig neubig merged commit 6491142 into main May 28, 2025
18 checks passed
@neubig neubig deleted the neubig/action-executor-key-error branch May 28, 2025 19:59
mamoodi pushed a commit that referenced this pull request May 28, 2025
@pekosoG
Copy link

pekosoG commented May 28, 2025

is this fix going to be auto-deployed? i saw the github actions building the ver 0.40.0 triggered out of this merge 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants