fix(image-input): enforce image types on upload #8054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
changed the title
LoneRifle
force-pushed
the
fix/thumbnail/enforce-img-type
branch
from
f6e67b1 to
f1d6f4b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enforces that only image files are uploaded by filtering files based on their MIME type before invoking the onUpload callback.
- Filters out non-image files by checking for MIME type starting with "image/"
- Updates the file upload handler in the image input component
Comments suppressed due to low confidence (1)
frontend/src/components/features/images/upload-image-input.tsx:11
- Consider adding tests to verify that the filtering logic correctly excludes non-image files from being uploaded.
const validFiles = Array.from(event.target.files).filter((file) =>
Ensure that only images are uploaded on the frontend - filter selected files to upload by MIME type - ensure that only blobs are accepted by thumbnail Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
LoneRifle
force-pushed
the
fix/thumbnail/enforce-img-type
branch
from
f1d6f4b to
a2e013f
Compare
rbren
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that only images are uploaded on the frontend, by filtering on MIME type